New Canary update broke CSS (0.0.204) about beautifuldiscord

[leovoel]

the fix itself is simple, it's just a setting they've changed that disables the node.js API access (used here for filesystem operations).

i'll wait a few days to push it.

also, i didn't see any changes to the client structure on disk on windows. i can take a look at it on linux as well, but osx i have no idea about.

[cloudrac3r]

the fix itself is simple, it's just a setting they've changed that disables the node.js API access (used here for filesystem operations).
i'll wait a few days to push it.

It's been a week, and it looks like this change is staying. Why not push the fix to another branch if you're worried about it being reverted again in the client?

[leovoel]

done (see ec03601), sorry to keep you waiting. let me know if there's any problems.

i should note that the nodeIntegration option was disabled for a good reason, and leaving it enabled comes with risks (e.g. any XSS exploit has more to play with in that case). this has always been an issue though (well, up until discord disabled it), and they haven't really suffered from attacks like that, so it's probably fine.

[VGrol]

Exact same situation on the Linux Canary builds.

[InkxtheSquid]

same here on mac

[InkxtheSquid]

ok, so far discord[ptb,canary] is no longer in ~/Library/Application Support/ on mac, so they moved it somewhere else now, and it seems like they moved it back into how it was before October 2017

[simoniz0r]

The updates should be reverted again, but they will more than likely get pushed again in a future update. This was just to test to see if these changes were going to cause bugs, and they didn't, so they will probably be back.

[Keanu73]

as of now there's been a new update that fixed this or possibly reverted. I have no idea but it's fixed now

[VGrol]

As per usual, discord likes to be inconsistent.
For the third time in the last 48 hours, the update was reverted, only to be reinstated.

CSS as of the last Canary push is no longer applying.

[doron-goldstein]

Status update on this? The change doesn't seem like its going to be reverted again.

[cloudrac3r]

Yep, seems to work fine. Apart from live-reload only reloading once, but that always happened and it doesn't bother me.