Comments (3)
Hi Trevor,
I wanted to have a single light for both Blender and POV-Ray, and people can configure the app specific settings if they want to. I think this works better because in general people would place the same light for both apps and tune app-specific parameters if needed but I'm happy to discuss.
General
- POWER default value changed from 10 to 1 - Consider using Blender default 1000
Default power for me in Blender is 10
ATTENUATION_DISTANCE
andATTENUATION_POWER
not expected by Blender
These are POV-Ray only (fade_distance and fade_power).
- Change transform
ROTATION
format from XYZ vectors to XYZ Euler angles
This is a rotation matrix, not vectors. You can convert it to euler angles like we do on the UI, but I'd rather save it as a matrix.
- When moved,
ROTATION
values in Properties do not match values in bottom-right UI message bar
We don't display the rotation on the status bar, what do you mean?
- No UI to distinguish between POV-Ray and Blender lights. For Blender lights:
See first paragraph.
* [ ] Exported `POWER` default is _1_ but Blender `POWER` default is _1000_
Default power for me in Blender is 10
* [ ] Pointlight `RADIUS` not exported, `SIZE` not expected * [ ] Spotlight `RADIUS` exported as first value of `SIZE` pair - e.g. `SIZE .2 0`
Size is radius, I can change the exported key for clarity.
* [ ] Directional light `ANGLE` not exported, `SIZE` not expected
Size is angle, I can change the exported key for clarity.
* [ ] Arealight `AREA_GRID` not expected
This is POV-Ray only
Pointlight
RADIUS
not exportedRADIUS
default changed from .25 to 0 - Consider using Blender default .1
Default radius in Blender is 0 for me
SIZE
not expected by Blender
See above.
- Spotlight
SPOT_BLEND
missing
SPOT_BLEND = SPOT_PENUMBRA_ANGLE / SPOT_CONE_ANGLE, I followed POV-Ray here because I thought it made more sense at the time, let me think about this one.
RADIUS
exported as first value ofSIZE
pair - Consider exporting asRADIUS
nRADIUS (SIZE)
default changed from .25 to 0 - Consider using Blender default .1
Default size in Blender is 0 for me
- Cannot enter more than 1 decimal place for
RADIUS (SIZE)
property
I'll take a look.
- Directional (Sun) Light
SIZE
not expected by BlenderANGLE
not exported
See above.
ANGLE
default changed from 11.4 to 0.0002
Default angle in blender for me is 0.526
- Arealight
AREA_GRID
not expected by Blender
See above.
I don't know why my defaults are different from yours (I have Blender 4.0), I don't mind changing them once we figure out what they should be.
I'll rename some of the keys for clarity.
from leocad.
I wanted to have a single light for both Blender and POV-Ray, and people can configure the app specific settings if they want to. I think this works better because in general people would place the same light for both apps and tune app-specific parameters if needed but I'm happy to discuss.
Indeed, and I agree. However, taking into account the different input parameter between POV-Ray and Blender, I felt it was necessary to distinguish between the two applications. To this end, I imagine one could consult the Parameter UI (as I did in the initial PR) or generate the appropriate indicator depending on the selected Render menu item selected. Nevertheless, I'll conclude that there won't be any behaviour to distinguish between POV-Ray and Blender.
Default power for me in Blender is 10.
Currently 10 is also the default I expect from the input file in blenderldrawrender. So if you revert to using 10, I would not have to make any changes.
These are POV-Ray only (fade_distance and fade_power).
Indeed. With no way to distinguish between POV-Ray and Blender, I imagine you are flushing parameters for both on save/export.
SPOT_BLEND
=SPOT_PENUMBRA_ANGLE
/SPOT_CONE_ANGLE
, I followed POV-Ray here because I thought it made more sense at the time, let me think about this one.
Very well. So as the default SPOT_PENUMBRA_ANGLE
value is 0 the default SPOT_BLEND
will calculate to 0 also.
This is a rotation matrix, not vectors. You can convert it to euler angles like we do on the UI, but I'd rather save it as a matrix.
Very well.
I don't know why my defaults are different from yours (I have Blender 4.0), I don't mind changing them once we figure out what they should be.
I'm using Blender 3.4.1, but I installed 4.1.0 and also got the same defaults. Perhaps these defaults depend on screen-size but I could not find any definitive information about this.
When moved, ROTATION values in Properties do not match values in bottom-right UI message bar
We don't display the rotation on the status bar, what do you mean?
When I move the Spotlight ROTATION handle, both the Properties and Status Bar values are updated; however, these values do not match. The same behaviour is exhibited when I move the POSITION handle and the values match.
Cheers,
from leocad.
FYI, here are the defaults from the Blender source: https://github.com/blender/blender/blob/2548132e23f55a4891f428a4f01e5b33023e6f63/source/blender/makesdna/DNA_light_defaults.h
from leocad.
Related Issues (20)
- Question: Filter colors by what is available in lego Pick a Brick HOT 1
- The parts in use filter doesn't update correctly when changing the part property
- Model for "Angled gear wheel z28" is missing from parts list. HOT 1
- [ANNOUNCE] The LeoCAD now distributed via MSYS2 on Windows
- Preview tab is empty
- New Parts properties widget 'Parts' combo dropdown has issues (WIP) HOT 7
- Bricklink Import Issue HOT 1
- Add Import option to the Models Dialog
- LeoCAD consistently crashes when trying to use Replace HOT 1
- Add a portable version HOT 3
- Save as image creates strange images that are totally wrong HOT 4
- Is there any way to pose minifigs besides through Minifig window?
- Scroll Wheel function HOT 2
- Fails to build against Qt6 on Windows HOT 1
- Missing file extension on export
- App won't open on Macs with case-sensitive filesystems HOT 1
- CLI to Export LDR File through different format HOT 1
- The asterisk indicating project modification is not updated until after some additional user activity
- Flathub Verification
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leocad.