Minifig Wizard Crash about test

[leozide]

Originally by [email protected] on 2006-05-16 16:39:01 -0400

---

Attachment added: minifig-missingleg.png (35.3 KiB)
A one legged minifig

[leozide]

Originally by [email protected] on 2006-05-16 16:52:00 -0400

---

I have taken the latest trunk version out of svn - and can confirm that both the missing leg, and crash behaviour can still be reproduced. I will take a look at the source for it, and see if I can see anything obvious.

[leozide]

Originally by [email protected] on 2006-05-18 17:54:15 -0400

---

Leo, I have also made some changes related to this bug, which I was about to commit - which may not have solved the root cause, but made the draw code more resilient by only attempting to redraw if the Leg peices are not set to null. This did prevent it crashing.

I have updated my local SVN, and your changes have merged with mine with no conflicts, and compiled. Do you concur that it would be wise to have the defensive test in anyway?

On my version, before your changes, certain leg selections would result in a blank leg.

[leozide]

Originally by leocad.gerf.org on 2006-05-18 19:27:21 -0400

---

The problem was that it was trying to find the pieces based on the description from the drop down list, which I shortened from the piece description to take less screen space but in some cases the leg names would conflict with torso names and I think that caused it to render a torso instead of a leg but it wasn't visible on the small window.

I've just added some more checks to make sure there's a valid leg piece before trying to access it, but if you have more safety checks feel free to add them, it doesn't hurt to be safe.

Do you still see any crashes or missing legs with my fix?

[leozide]

Originally by [email protected] on 2006-05-27 12:54:44 -0400

---

Hi Leo,
Sorry I hadnt gotten back quicker.
Didnt see the crashes, and I see (after doing an update and getting conflicts) that you have similarly now made the safety check changes. I did actually use

if(m_Info[LC_MFW_LEFT_LEG] != NULL)
over
if(m_Info[LC_MFW_LEFT_LEG])

just out of defensive coding habits, but thats a good safety check to have.
Danny