GithubHelp home page GithubHelp logo

Gin -> ARPC integration about arpc HOT 7 CLOSED

lesismal avatar lesismal commented on June 26, 2024 2
Gin -> ARPC integration

from arpc.

Comments (7)

lesismal avatar lesismal commented on June 26, 2024 1

Sorry for late update, I just made the commit to update the websocket server example based on gin, it's simple here:
https://github.com/lesismal/arpc/blob/master/examples/protocols/websocket/server/server.go#L51

from arpc.

lesismal avatar lesismal commented on June 26, 2024

Awesome job bro! I would appreciate it very much!
If you like, welcome to make a PR to add the gin-arpc example to arpc/examples, but just make it simple(no need other 3rd libs such as zap logger).

from arpc.

KevM avatar KevM commented on June 26, 2024

Ok. How about I port the logger to be log/slog?

from arpc.

lesismal avatar lesismal commented on June 26, 2024

Ok. How about I port the logger to be log/slog?

arpc/log.Logger is interface, users can implement arpc/log.Logger interface and set DefaultLogger = UserLogger, and we need to keep compatibility with old versions of go.
So we shouldn't use slog.

from arpc.

github-actions avatar github-actions commented on June 26, 2024

This issue is stale because it has been open for 30 days with no activity.

from arpc.

KevM avatar KevM commented on June 26, 2024

Did you want any help adapting my PR? Looks like you closed it. Not sure what gap I have that didn't make it acceptable.

from arpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.