Webgrid 2.0 about webgrid

[tjlevel12]

Perhaps this is covered in "Streamlined control flow and clearer abstractions", but I'd like to see some changes to the grid internals, in order to improve testing.

Right now, the grid knows about the column, but the column also knows about the grid, to the point where the columns won't work without the grid. This means that you can't test the columns in isolation.

I'd prefer the grid knows about the columns, and when rendering happens the grid passes down whatever details the column needs to know in order to properly render its data. This then permits tests against individual columns, rather than needing to bootstrap and test an entire grid as a whole.

[matthiaswh]

Mobile responsive. See #84 for possible implementations.

[calebsyring]

This may or may not be an issue, but it's probably something to note: pagination does not reset when filters change on a webgrid. Here's an example to show the potential problem with that:

Reviewing time records as an admin in Finitude, I'm going through two pages of records filtered by the Evolve client. When I finish reviewing them (on the second and last page), I switch my filter to the Level 12 client (for which there are 4 pages of records). When I do this, the way webgrid works, I start on the second page. If I'm not paying attention, I could miss reviewing the entire first page of the Level 12 records.

-- Me

There's an argument to be made for a change, but the UI is kind of in the way of that - you add a filter and submit, but the page fields still have the other page selected. So the user is getting exactly what is "asked" for, even though it's not necessarily helpful.

-- Matt

[matthiaswh]

This may or may not be an issue, but it's probably something to note: pagination does not reset when filters change on a webgrid.

Adding one more voice to the conversation, one of our clients opened a support ticket because they couldn't figure out why they were seeing strange results on one of their grids.

It also results in inconsistent behavior in some situations. If you are on page 6, then filter to where there are only 4 pages of results you go to page 4; but then if you clear the filter you just added (going to your original search) you end up on page 4 instead of where you started on page 6. So even if you learn this behavior you can't integrate it into your workflow because it's unreliable.

IMO pagination should be independent of the rest of the filters and should reset to page 1 on every filter change.