Comments (5)
mlasson
commented on July 26, 2024
3
You are right. May be we should remove "index_get/_set" from the automatic selection of attributes to preserve backward compatibility.
Maybe, we should deprecate the whole idea of automatic selection of [@@js.*] attributes.
It is too fragile and not trivial to guess at a glance.
from gen_js_api.
nojb
commented on July 26, 2024
cc @mlasson
from gen_js_api.
TyOverby
commented on July 26, 2024
Maybe, we should deprecate the whole idea of automatic selection of [@@js.*] attributes.
Put me firmly in the "no magic" camp!
from gen_js_api.
TyOverby
commented on July 26, 2024
What other function names could change behavior?
from gen_js_api.
mlasson
commented on July 26, 2024
What other function names could change behavior?
I think "get/set" should be the only one. But I would not bet my hand on it.
Using the current "master" version, you will have warning for each "unannotated" declarations; you should use that to help you annotate all of them.
I'm sorry for the inconvenience; but hopefully it will be the last time we suffer from this problem.
from gen_js_api.
Related Issues (20)
- calling new on a dynamic value HOT 4
- Conversion functions not included in module signature HOT 1
- js.global with payload doesn't work with js.scope HOT 1
- Change Ojs_exn to Ojs.Exn HOT 2
- Make a new release HOT 2
- [question] How to define mutually recursive types including both JS-able types and non-JS-able types (with custom `of_js` and `to_js`)?
- Resolve the ocaml-migrate-parsetree < "2.0.0" constraint HOT 2
- Recursive type definitions generate invalid `let-rec` definitions
- [@@js.new] can infer empty class names
- js.* attributes on val declarations fail to compile in 1.0.7 HOT 3
- Ignore @js.dummy attribute for the spuriousness check HOT 1
- Add visual feedback of executed JavaScript code HOT 1
- Contravariant type parameter 'a is not allowed
- Inherit JS class, override method and pass new class back to JS? HOT 1
- Support ad-hoc object types to map to JS objects
- Unions based on JS class name and typeof?
- "js.union without way to discriminate values" for union in callback argument type HOT 1
- Dots in js.scope HOT 3
- Using polymorphic types with `js.custom` and `js.call` gives weak polymorphism error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gen_js_api.