Update the S4 objects used in Sequences? about 2017-04-03-adv-r-progr-embl

[lgatto]

Ok. There is a sequence function, though.

[rstojnic]

So what is the preferred solution here, something like this?

setMethod("sequence", "ANY", function(object,...) base::sequence(object))

[rstojnic]

Added in: ab05dc0

[lgatto]

I think it should be

.A <- setClass("A", slots = c(a = "numeric"))
a <- .A(a = 1)

setGeneric("sequence", function(nvec, ...) standardGeneric("sequence"))
setMethod("sequence", "ANY", function(nvec) base::sequence(nvec))
setMethod("sequence", "A", function(nvec) print("A.sequnece"))

sequence(1:3)
sequence(a)

[rstojnic]

base::sequence() is not a generic, so there is no obligation to keep the same parameter names?

[lgatto]

1. Set generic, that doesn't exists. Not sure if we need to use nvec here. Will test.
2. Default implementation, that calls the base function, to recover it.
3. New method for our class.

[lgatto]

Indeed, we can rename the argument:

.A <- setClass("A", slots = c(a = "numeric"))
a <- .A(a = 1)


setGeneric("sequence", function(x, ...) standardGeneric("sequence"))
setMethod("sequence", "ANY", function(x) base::sequence(x))
setMethod("sequence", "A", function(x) print("A.sequence"))

sequence(1:3)
sequence(a)

[rstojnic]

Alright then, I'll keep it as it is in the commit quoted above.