GithubHelp home page GithubHelp logo

Comments (7)

epogrebnyak avatar epogrebnyak commented on May 26, 2024 1

Aha, I am missing dot, but this is not exactly the error message:

Q:\slipbox
λ python -c"from shutil import which; print(which('dot'))"
None

from slipbox.

epogrebnyak avatar epogrebnyak commented on May 26, 2024 1

So it appears

if not check_requirements(app):
error("pandoc not found")
checks for both pandoc and dot, but the error message will be pandoc not found even if pandoc is present and dot is missing.

I can split the check into two functions and add extra error message if you'd advise me to.

My initial problem is solved by installing graphviz, and I'm looking forward to experimenting with slipbox, very excited about it.

from slipbox.

epogrebnyak avatar epogrebnyak commented on May 26, 2024 1

Probably even a more simple fix for a PR is adding more verbose error message, eg "Either pandoc or graphviz not found, aborting..."

or

to do has_pandoc(app) and has_dot(app) in dependency.py (which I think simplifies the check a lot and allows to separate the error handling):

def has_pandoc(app):
   return which(app.config.pandoc)

def has_dot(app):
   return which(app.config.dot)

from slipbox.

lggruspe avatar lggruspe commented on May 26, 2024 1

fixed in c15afe0

from slipbox.

epogrebnyak avatar epogrebnyak commented on May 26, 2024

def check_requirements(app: RootlessApp) -> bool:
"""Check if all runtime requirements are satisfied."""
requirements = [
app.config.pandoc,
app.config.dot,
]
return all(map(which, requirements))

from slipbox.

lggruspe avatar lggruspe commented on May 26, 2024

I would go with the second option, so the error messages can be more specific.

from slipbox.

epogrebnyak avatar epogrebnyak commented on May 26, 2024

Thank you for following up on this @lggruspe !

from slipbox.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.