Comments (8)
Thanks. The script doesn't use any .css("border-bottom","");
, so do you mean e.g. $that.css({ 'display': '' });
isn't working in IE8?
I've tested the demo again in IE8 (emulation mode), but it seems to be fine, could this only be in the real IE8 browser only? Could it be a jQuery version issue?
from jquery-match-height.
yes. specifically i meant this part.
// revert the temporary forced style
$elements.css({
'display': '',
'padding-top': '',
'padding-bottom': '',
'border-top': '',
'border-bottom': '',
'height': ''
});
BTW, looks fine to me, but you know how IE8 is...
tested the demo page straight from download in IE8 on a VM and im still getting the issue.
i also tested in IE9 and was able to reproduce the issue when using IE8 "document mode". IE8 "browser mode" did not reproduce.
i have included a screenshot. i guess we can rule out jquery version issue, as i was using your full package with its version of jquery.
Please let me know if there is any other info you need an thanks again for all the awesome work.
from jquery-match-height.
Ok so, turns out that there's specifically bugs with that approach in < IE8:
http://stackoverflow.com/questions/4036857/jquery-remove-style-added-with-css-function
@Runeform for now, I think you should modify your copy to use the .removeAttr('style');
approach?
I still need to think if that is appropriate to roll into the plugin myself though, since I'd rather not just remove the whole inline style attribute (in case other plugins are using it).
from jquery-match-height.
wouldnt that remove the height that matchHeight places on the object? or does all that happen before the height is applied?
from jquery-match-height.
Yep that happens before the height is applied (see these lines), so should be fine.
That part of the code is preparation for finding rows.
from jquery-match-height.
actually i just found a work around
// must first force an arbitrary equal height so floating elements break evenly
$elements.css({
'display': 'block',
'padding-top': '0',
'padding-bottom': '0',
'border-top-width': '0',
'border-bottom-width': '0',
'height': '100px'
});
// get the array of rows (based on element top position)
rows = _rows($elements);
// revert the temporary forced style
$elements.css({
'display': '',
'padding-top': '',
'padding-bottom': '',
'border-top-width': '',
'border-bottom-width': '',
'height': ''
});
since its not setting the additional properties of "border" it does leave the border style and color behind and removes successfully
from jquery-match-height.
*it does 'not' leave...
from jquery-match-height.
Ah, looks like that might do the trick. I'll try that out and push it if it works, thanks.
EDIT: tested working fine, cheers
from jquery-match-height.
Related Issues (20)
- Footer not staying on bottom of div HOT 3
- Rounding down height HOT 2
- Firefox Quantum problem HOT 2
- Add option to disable auto matching data-mh HOT 2
- It is posible to disable byRow option with data-api? HOT 2
- Columns only firing on window reload w/AJAX + Facet WP HOT 1
- Match height only working on certain pages HOT 1
- only firing on some elements, not all - but all on resize HOT 4
- wildcard target class?
- Latest jquery HOT 4
- Matchheight stopped working on orientation change on all my sites HOT 1
- Height matching AJAXed elements using [data-mh] method HOT 2
- How to work with Accrodion content Parent matchheight detected rows should still work.
- A different, faster approach?
- Overlapping elements HOT 2
- Issue with nth-child and display property.
- Having multiple 'property' attributes
- Error
- documentation for _update and _applyDataApi
- When Code Splitting and adding jquery-match-height to the second script file it fails to register.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-match-height.