`setup.py` doesn't install submodules. about workflow

[noambernstein]

They are no longer sub modules, but dependencies. Those are listed in setup.put (should be) and It should get those automatically from github.

…

On Fri, Nov 19, 2021 at 4:02 PM gelzinyte ***@***.***> wrote: All modules need to be listed in setup.py, not just packages=["wfl"]. Same goes for UniversalSOAP and ExPyRe. Would packages=setuptools.find_packages(exclude=["test"]) do what you wanted to do in cc4aceb? Though I've tried that and no modules get listed still (but wfl works): In [1]: import wfl In [2]: dir(wfl) Out[2]: ['__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__'] — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBMJRXXGOYRWYU2CTGTTTDUM23ODANCNFSM5INAH7OA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[bernstei]

Oh, OK, I misunderstood. Yes, find_packages(exclude is the right way to do things. I'll fix it.

[bernstei]

However, I also realized that make html is using the installed wfl, not the current source tree, which I think is going to be confusing. Can I add "${PWD}/.." to PYTHONPATH in docs/Makefile?

[bernstei]

I think the find_packages stuff should be fixed everywhere. Is it normal to get lots of warnings about the docstrings?

[bernstei]

I'm cleaning up the docstrings to reduce the amount of output from make html. Maybe half way done so far?

[bernstei]

@gelzinyte can you confirm that I've fixed the submodule stuff in the latest version? I'd like to close this issue, and we can deal with the docs in another one.

[bernstei]

You may need to remove the current expyre-wfl and universalSOAP installations, because I had to update setup.py in those as well.

[gelzinyte]

Yes, thank you for fixing this.