Confused on something about cpr

[COM8]

Sorry for the delayed response. I've been on vacation :)

In theory curl_easy_cleanup gets called when the cpr::Session and corresponding cpr::Reponse objects are destructed.
Ref:

cpr/cpr/curlholder.cpp

Line 28 in 1ad1cd2

curl_easy_cleanup(handle);

In my small test case curl_easy_cleanup is called properly every time:

TEST(SessionGetTests, GetSessionDestructor) {
    {
        Url url{server->GetBaseUrl() + "/hello.html"};
        Session session;
        session.SetUrl(url);
        std::string expected_text{"Hello world!"};
        Response response = session.Get();
        EXPECT_EQ(expected_text, response.text);
        EXPECT_EQ(url, response.url);
        EXPECT_EQ(std::string{"text/html"}, response.header["content-type"]);
        EXPECT_EQ(200, response.status_code);
        EXPECT_EQ(ErrorCode::OK, response.error.code);
    }

    {
        Url url{server->GetBaseUrl() + "/hello.html"};
        Session session;
        session.SetUrl(url);
        std::string expected_text{"Hello world!"};
        Response response = session.Get();
        EXPECT_EQ(expected_text, response.text);
        EXPECT_EQ(url, response.url);
        EXPECT_EQ(std::string{"text/html"}, response.header["content-type"]);
        EXPECT_EQ(200, response.status_code);
        EXPECT_EQ(ErrorCode::OK, response.error.code);
    }
}

Can you provide an example for reproducing it?

[bleriaf]

well i guess it does because the program closes once it finishes doing both, what if you try doing this does the cleanup still get called?

int main() {
        Session session;
        session.SetUrl(cpr::Url{ "https://google.com" } );
        Response response = session.Get();
        printf( "ret: %s ", response.text.c_str( ) );

       while ( true ) {
              Sleep( 1000 );
       }
}

[COM8]

Your example is highly dependent on your compile optimisation level. You compiler might catch the while infinite loop and never call the destructors.

A better solution would be:

int main() {
        {
            Session session;
            session.SetUrl(cpr::Url{ "https://google.com" } );
            Response response = session.Get();
            printf( "ret: %s ", response.text.c_str( ) );
        }

       while ( true ) {
              Sleep( 1000 );
       }
}