libevent allows blocking fds in the event loop about libevent

[nmathewson]

I'm fine with a debug-mode feature that checks for blocking sockets when they're added.

(There should be a way to turn it off, though: while I think it's silly to wait on blocking sockets, I have seen code that does this.)

[ghazel]

Bleh, it seems Windows doesn't have a mechanism for checking that a socket is nonblocking.

How do you imagine the switch for turning it off would work? Compilation flag? Runtime option?

[nmathewson]

Most debugging stuff is controlled by the event_debug_mode runtime logic in event.c , and disableable completely with the --disable-debug-mode configure flag that controls the EVENT__DISABLE_DEBUG_MODE macro.

[errzey]

We have to look out for LEV_OPT_LEAVE_SOCKETS_BLOCKING sockets now.

[azat]

I think that the purpose of the LEV_OPT_LEAVE_SOCKETS_BLOCKING is that you pass fd somewhere else, IOW you should not add this fd to the event base.

So I assume that we can apply nmathewson/Libevent#90

Objections? @nmathewson @NathanFrench

[NathanFrench]

Nope. Looks good here.

[azat]

Closing this one in favor to nmathewson/Libevent#90