Repository ctor should be able to handle working folder about libgit2sharp

[nulltoken]

Hey David, this issue looks very similar to #25. Would it be a duplicate?

[tclem]

This is similar, but not exactly the same as #25. I think what @davidebbo is asking for here is to look into a single directory for a .git dir. #25 is asking for a feature that traverses up to find a parent directory that contains a .git dir.

@davidebbo - I'm all for this and actually implemented something very similar in the objective-c bindings. Might be helpful to look at if you are thinking about implementing.

[nulltoken]

From what I've read in the libgit2 code (libgit2/libgit2@793545e#L4R501), git_repository_discover does the following: search for a sub .git folder, tries to consider current path as a bare repo, then browse upward the tree structure repeating the same pattern. It even supports the gitdir: redirect.

So, best of both worlds?

[davidebbo]

I think the primary use case is indeed when passing the root of the working folder. Having it work on any sub-folder of the working folder would match the git command line behavior, though from an API point of view it would be less likely to be useful. My take is that the caller always knows the root working dir folder, and passing that is easier than having to append "./git" to it.

Anyway, for the most part this is indeed a dup of the other bug, with some slight nuances that probably don't justify tracking separately.

[nulltoken]

As the discussion moved toward #25, I'm closing this one.