Tests do not pass any longer on Mono/Windows about libgit2sharp

[nulltoken]

A bug report has been filled @ http://bugzilla.xamarin.com/show_bug.cgi?id=2266

[nulltoken]

• Updated the bugzilla with a repro case
• Had a (very cool) chat session with @joncham on this topic.

[joncham]

So, I think I tracked down the issue. The problem is here: https://github.com/libgit2/libgit2sharp/blob/vNext/LibGit2Sharp/Core/NativeMethods.cs#L30

A call to a pinvoke method is in the same method that sets the PATH variable. When mono attempts to JIT the .cctor of NativeMethods it tries to load git2.dll. Note this is when JIT'ing the method itself. That means the body of the method has not yet executed, and the PATH variable has not been adjusted. I think the easiest way to solve this is to extract the pinvoke call, git_threads_init, into a separate method that can be called from the .cctor and mark it with the NoInlining option. This should give the JIT the chance to run the body of the .cctor before trying to resolve the native library for the pinvoke call.

[MethodImpl(MethodImplOptions.NoInlining)]
static void InitGit()
{
NativeMethods.git_threads_init();
}

[joncham]

And I created a pull request: #190

[nulltoken]

And I created a pull request: #190

@joncham And I (gladly) merged it...

...And you're fantastic!