Error not thrown as expected in `Tree#getEntry()`. about node-gitteh

[samcday]

Hey there,

Good find, I'll investigate this shortly!

On Wed, Mar 30, 2011 at 2:54 PM, TooTallNate <
[email protected]>wrote:

You can see in the REPL output below, a proper Error object isn't being
created with the getEntry() call. Let me know if you need any more info!

repo = require('gitteh').openRepository('.git')
commit = repo.getCommit('6a355a4cd8f47bfc2d7c5ee951705b8baad5c711')
commit.getTree().getEntry('doesNotExist')
null // Expected an Error to be thrown here, not null returned...
commit.getTree().getEntry('doesNotExist', console.log)
{ stack: [Getter/Setter], arguments: undefined, type: undefined,
message: 'Couldn't get tree entry.' } // no stack, no error codes,
arguments and type are undefined...

Reply to this email directly or view it on GitHub:
#5

[samcday]

Hey man,

Just looked into this, I'm throwing an error from the async codepath but only returning null from the synchronous code path. Oops...

Anyway look, I'm about to push out a new version which removes getEntry() altogether anyway. Instead the entries are just added in an array to the tree as a property, so you'll just go tree.entries[0] for example. I'm not going to bother adding the ability to get an entry by name, as searching for it using JS array mechanics is going to be a hell of a lot faster than calling into the native library to do it for you.

I'll be pushing these changes out fairly soon, I'll keep you posted!

[samcday]

Hey,

I released 0.1.0 tonight, which removes the need for Tree.getEntry completely. Instead you can just manipulate tree.entries array.

Closing this issue now