GithubHelp home page GithubHelp logo

Comments (4)

Stebalien avatar Stebalien commented on July 3, 2024 1

Please do submit a PR to remove that comment. And yes, a comment in the README stating that this repo does not use gx would be great!

from go-libp2p-examples.

Stebalien avatar Stebalien commented on July 3, 2024

The binaries should build without gx. That's why we aren't using it (we don't want to make users think they have to use gx to use libp2p).

Make sure you have a clean gopath.

from go-libp2p-examples.

raulk avatar raulk commented on July 3, 2024

Agree with @Stebalien. I’d prefer to avoid imposing our world view (gx) to Go developers, unless inevitable. It seems unnecessary in this case, and what you’re seeing is probably the product of some dependency not being clean in your gopath.

Try running a go get -d -u ./.... That’ll update your local deps and scream in case of local changes.

from go-libp2p-examples.

petroav avatar petroav commented on July 3, 2024

@Stebalien @raulk yep, that makes sense. I definitely don't have a clean gopath as I've checked out and built the other repos. I also got confused by this comment https://github.com/libp2p/go-libp2p-examples/blob/master/http-proxy/proxy.go#L14.

Should I update the README warning other developers of this (not having a clean gopath) and removing the above comment?

from go-libp2p-examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.