GithubHelp home page GithubHelp logo

Comments (2)

ubruhin avatar ubruhin commented on May 13, 2024

Until now, Qt's smart pointers are used instead of the C++11 ones. The only disadvantage seems to be that QScopedPointer has no move semantics. As a workaround we could use QSharedPointer where move semantics were required.

The other way would be to replace all Qt smart pointers with C++11 ones and don't use Qt pointers any more.

C++11 smart pointers never throw std::exceptions by themself, do they? If they do, we would have to wrap them with our own exception classes...

from librepcb.

ubruhin avatar ubruhin commented on May 13, 2024

I consider this as closed for following reasons:

  • C++ smart pointers can throw exceptions in many situations. So we would have to wrap all std::exception with our own librepcb::Exception class. This is PITA.
  • Qt's smart pointers are already widely used in LibrePCB. And in every new class I'm creating or refactoring, I use smart pointers instead of raw pointers where applicable.
  • Replacing all old raw pointers with smart pointers at once would require lot of effort. I think it's better to replace them step by step when refactoring old classes. Most of the classes will need some refactoring anyway at some point...
  • Using smart pointers is now recommended in the developers documentation.
  • Maybe Qt provides a unique pointer with move semantics someday ;) Until then we can use QSharedPointer instead.

from librepcb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.