Tempest has no player 2 buttons or spinner about mame2003-plus-libretro

[mahoneyt944]

Inputs fully working now. 32fa606 😁

[arcadez2003]

We need this fix from later builds..

0.102u3: RansAckeR fixed cocktail mode and input in Tempest.

I'll look into it sometime

[mahoneyt944]

I noticed in the description that the cocktail mode may have been planned but not implemented. Looking at mame2010, it looks like they just replaced the p1 hooks with special ports to essentially inject both players over this port. I imagine with custom read functions and a little bit of logic to check against the cocktail DSW this should work out.

[arcadez2003]

Yeah i just noticed this...
0.112: Stephane Humbert updated Tempest to support 2nd Player controls.

The first fix above is for the screen flipping and this one will add the 2nd input by looks

EDIT oh oh lots of port by tagging calls which wont work here without modifications

[mahoneyt944]

I patched in the cocktail controls, to what I believe it should be for this core. 99644cc

@rdagger are you basically using a single mouse as two spinners? P1x and P2y? If so you'll need to turn on dial share I believe under input options.

[mahoneyt944]

@arcadez2003 the flip screen is still a little buggy not sure what that fix was exactly but likely need it too

[arcadez2003]

@mahoneyt944 This is the fix circa MAME102.u3
c3e15eb

Notice our flipping calls were different to what the fix above was added into...

void avg_set_flip_x(int flip)
{
if (flip)
flip_x = 1;
}

void avg_set_flip_y(int flip)
{
if (flip)
flip_y = 1;
}

I had a quick look about the video and driver i seen no diffs as per when the above changes to the flip calls
were done but we might need to dig deeper should my commit not iron out the niggles

[rdagger]

@mahoneyt944 I'm using a single mouse as two spinners. Thanks!

[mahoneyt944]

That's probably all it needed!, thanks @arcadez2003 for getting that solved. @rdagger is everything good on your end? can we close this?

[rdagger]

@mahoneyt944 won't be able to test for a few days, but it sounds great, thanks guys!

[mahoneyt944]

@arcadez2003 update, unfortunately still bugging out a little. Noticed bumping the dial can cause it to correct. So might just be interference reading the port when it switches.

[arcadez2003]

@arcadez2003 update, unfortunately still bugging out a little. Noticed bumping the dial can cause it to correct. So might just be interference reading the port when it switches.

Aye it might just be

[mahoneyt944]

Yeah it's something like that, if you don't move the cocktail dial it bugs out on the player 2 level select, moving the dial corrects the issue. Probably need to log this port and see what's happening.

[mahoneyt944]

For some reason when this port is low it flickers the flip bit as the dials rotates. When switched to high, it works normally but I had to flip the cabinets bits to play nice with it. Seems to work ok now. b61da75

I haven't followed the logic of port_custom in newer mame to see how exactly it binds these functions to the port, so perhaps it does a similar inversion behind the scenes?

[mahoneyt944]

I also found that the difficulty dip switch is reversed now. Might need a better way of linking the ports than adding them together as I think that's causing the oddity.

[rdagger]

Did a quick test and everything looks great, thanks!

[arcadez2003]

Alright then another happy ending so we can close this down.