Comments (7)
Maybe instead of creating a new instance of StrongSocket for each game we should keep a global one and pass it to each game controller.
from lichobile.
But sockets are created for a URL that contains the game ID?
from lichobile.
We could add the id
param to StrongSocket.reset
since we already reset version.
So we'd create 2 instances of StrongSocket one for game, one for lobby, on app init.
What do you think?
Also playCtrl should be removed completely as there's nothing left here... all should be done in round
from lichobile.
I don't think you can reuse a socket connection for distinct games. A round socket is bound to one game, defined by the round socket URL.
from lichobile.
nevermind, there's a confusion between instances of StrongSocket and actual browser WS connection.
from lichobile.
Yes reset could have an URL aargument additionally to version, to allow reuse of the StrongSocket instance while changing the underlying connection
from lichobile.
Yep that's what I meant. I think this is a fair approach to the problem mentioned above. And maybe it'll solve other issues...
from lichobile.
Related Issues (20)
- Puzzle mix - never given white pieces
- Question HOT 1
- Phantom Rook (holdover from previous puzzle)
- Unable to view imoortated gamesUnable to view imported items
- Crashing of app
- “Give more time” preference not saved
- Checkmate highlight on wrong king
- Hung online game against computer
- Login type password missing option to show it instead of asterisks
- iPadOS Mouse Support
- Bromite bug: Pieces + other stuff not showing on analysis board and puzzles.
- No move sounds after iOS update
- Clock is not visible - hidden behind the board on Samsung Galaxy Z Fold 5 wide view: critical for bullet games
- pieces can be moved randomly
- Dead video link on About page
- Lichess analysis board recommends same move twice by arrows
- Lichess keeps randomly joining me in games
- Incorrect piece advantage HOT 1
- No moves close to next button in analysis mode
- Android create Study ... isn't working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lichobile.