GithubHelp home page GithubHelp logo

Comments (11)

lightbeam24 avatar lightbeam24 commented on June 4, 2024 1

Yeah 2014-2017 should all be the same, there isn't much of a need to test them all. They share most of their code, excluding the watch page.

from customtube.

lightbeam24 avatar lightbeam24 commented on June 4, 2024 1

Okay, so that adds weight to my theory that PocketTube uses it's own CSS to style its sidebar items. I'll look into fixing it.

from customtube.

lightbeam24 avatar lightbeam24 commented on June 4, 2024

I haven't used PocketTube, but based on your screenshot, it looks like PocketTube is creating its own sidebar elements that use separate styling from the native YouTube sidebar items. So basically this only happens because CustomTube wasn't tested with PocketTube. (The only other extensions/scripts CustomTube was tested with are uBlock Origin and Return YouTube Dislike.)

I'll look into it though. In the meantime, could you tell me if it happens on other layouts? In this situation, it would be most helpful to test on the 2013, 2017, and 2019 layouts. If it happens on all three of those layouts, test it with "Layout Select" set to "Disabled".

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on June 4, 2024

In the 2013, the PocketTube is not only inaccessible, but also large, and the “Deck” button has an icon, and also under some icons there are grey YouTube buttons underneath them (Wait for me to test the 2017, and 2019 please…)
image

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on June 4, 2024

2014 PocketTube is clickable, but the buttons are large, and “Deck” button is misaligned (Not unclickable, sorry), and Deck have bad outline (Sorry, but you must wait, because I have some things to do with Firefox's CSS, so be patient…):
image

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on June 4, 2024

Well, 2015 is same as 2014. (Sorry for delay, but I changed some CSS files in my Firefox (Which are unrelated to this issue))

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on June 4, 2024

2016 is ditto as 2015, and 2014.

2017 is also the same.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on June 4, 2024

And for 2019, then there is wrong outline shade for Deck button, and the Sub. Collections are using wrong buttons shape, they should be square instead of rounded. (And Sub. Collections are clickable/accessible!)

image

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on June 4, 2024

Please, I need your answer, is this blue tick mark feature of YouTube, or feature of PocketTube?
image

  • If it is feature of YouTube, then it needs to be fixed (because it is off-set), if it is feature of PocketTube, then I don't know.
  • It is early 2013 layout.

from customtube.

lightbeam24 avatar lightbeam24 commented on June 4, 2024

I don't have that blue checkmark, so it must be PocketTube.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on June 4, 2024

Fine, I will write it to description, and title.

UPDATE: It is right in description. Not title for now, because I don't have any idea how the title should be written with more things.

from customtube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.