Comments (9)
let’s keep it as is for now. i don’t want to introduce breaking changes often (pytorch-lightning)
from lightning.
yeah, the problem was that there were issues with the test models being outside of the package.
But if you want to make the change, I do think it would be cleaner. Feel free to submit a PR! It would be super helpful!
Tests will also need to be updated.
from lightning.
Awesome PR, thanks for submitting! Interested in looking at any of the other issues we need help with?
from lightning.
I was thinking about some workaround automatic testing, formation and coverage...
I will prepare another PR :)
from lightning.
amazing! That would be great. Right now a big issue is having to manually run the GPU tests for free.
I'll create an issue to track these changes there
from lightning.
I am new to python packages, modules and stuff but I think that now that the directory examples
is in the root, the setup.py
detects it as a package with find_packages()
.
This results in anyone installing your pytorch-lightning
package to also have a examples
package installed into their environment.
As a matter of fact, it is preventing me from loading one of my local module named examples
.
from lightning.
The above commit could solve this.
It simply excludes the directory from the package.
Note that it also excludes the tests
which should be causing the same type of problems.
I will proceed with a pull request if it makes sense to you @williamFalcon @Borda.
from lightning.
I do agree with the change, or even explicitly name the 'pytorch-lightning'
Btw, why the package is imported pytorch...
not just torch...
such as PyTorch
from lightning.
Whitelisting as you suggest seems a good idea BUT doing so, sub-packages will not be imported.
About the name, I also think torch-lightning
makes a lot of sense.
from lightning.
Related Issues (20)
- Construct objects from yaml by classmethod
- FSDP Strategy checkpoint loading
- Current FSDPPrecision does not support custom scaler for 16-mixed precision
- Differentiate testing multiple sets/models when logging
- Issue in Manual optimisation, during self.manual_backward call HOT 1
- Existing metric keys not moved to device after LearningRateFinder
- Checkpoint every_n_steps reruns epoch on restore HOT 3
- Metrics logged by self.log and metric.compute() are different HOT 1
- Multi-node Training with DDP stuck at "Initialize distributed..." on SLURM cluster HOT 3
- Full validation after first microbatch when training after LearningRateFinder
- Add a warning when some of the modules are in eval mode before the training stage
- why pytorch-lightning doc say "Model-parallel training (FSDP and DeepSpeed)". I think there is something wrong. HOT 1
- AWS Trainium fails number of device validation when using more than 1 accelerator on the instances
- OnExceptionCheckpoint: training resumes if ckpt found, even if no ckpt_path provided
- TensorBoardLogger has the wrong epoch numbers much more than the fact
- How to incorporate vLLM in Lightning for LLM inference?
- WandbLogger `save_dir` and `dir` parameters do not work as expected.
- Loading large models with fabric, FSDP and empty_init=True does not work
- Unable to extract confusion matrix as a metric from trainer
- Torchmetrics Accuracy issue when dont shuffle test data. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning.