Comments (5)
Hi @Andrewwango, thanks for correcting me. I am not a expert on these metrics and just saw that the original paper defined it by multiplication and division. Sorry on my part.
I make sure to fix it.
from torchmetrics.
Hi! thanks for your contribution!, great first issue!
from torchmetrics.
Hi @Andrewwango, thanks for raising this issue.
I do not agree that there is an error in our formulation. If you look at the original paper by Wald (page 163 in the pdf) you will see that ERGAS metric is defined by multiplying the fraction and not dividing it. If you look at the paper by Du et al that you refer to, in equation (1) they ERGAS metric they multiply the ratio h/l
. I am not sure why it is different in the paper by Meng et al.
I am updating the metric to reference the original paper and the specific formula we are using for calculating the metric in #2426
from torchmetrics.
I disagree @SkafteNicki . The Wald and Du papers multiply by the ratio of pixel lengths , which is the inverse of the ratio. For example for ratio=4
the pixel length ratio h/l=1/4
. The Wald paper gives examples of h/l=1/4
and h/l=1/2
. Azarang et al states that h/l=1/4
for common satellites Pleiades-1A, WorldView-2, and GeoEye-1.
Therefore you should be dividing by the integer ratio. Please reopen this issue @SkafteNicki @Borda 😄
from torchmetrics.
Hi @SkafteNicki, any progress on this?
from torchmetrics.
Related Issues (20)
- Discrepancy in optimal threshold calculation between sklearn and torchmetrics ROC implementations HOT 2
- Mean Average Detection ignores `warn_on_many_detections` set to False HOT 1
- `list` states leak (`Tensor`) memory HOT 1
- Behaviors of AUROC and Average Precision are inconsistent when all labels are equal HOT 4
- The default value of `compute_with_cache` should be `True` . HOT 2
- Bug in ERGAS HOT 2
- Ordinal classification metrics HOT 1
- Binary Classification Expected Calibration Error HOT 2
- `intersection_over_union` error HOT 2
- Clarify that nan is supported in zero_division HOT 4
- Add `_filter_kwargs` in `ClasswiseWrapper` metric wrapper HOT 3
- `MetricTracker` use `higher_is_better` as default for maximize HOT 2
- Unpredictable class order when `panoptic_quality(..., return_per_class=True)`
- torchmetrics Accuracy HOT 8
- BootStrapper.reset() does not reset properly
- segmentation.MeanIoU is wrong HOT 3
- DataLoader worker is killed in Docker HOT 4
- MeanAveragePrecision - bug in `max_detection_thresholds` HOT 3
- Documentation of ERGAS HOT 1
- Support for DLM (AIM) metric HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from torchmetrics.