GithubHelp home page GithubHelp logo

Comments (12)

simlu avatar simlu commented on May 29, 2024 8

Any update on this?

from joi-to-json-schema.

vgjenks avatar vgjenks commented on May 29, 2024 2

@simlu Works brilliantly, thank you! Will come back w/ feedback as I throw more complex schemas at it.

from joi-to-json-schema.

yeongjet avatar yeongjet commented on May 29, 2024 1

I forked this project in my repo then rewrote some code using typescript and made some adjustments to fit joi v16.0, almost test cases passed. May I make a pull request? @lightsofapollo

from joi-to-json-schema.

yeongjet avatar yeongjet commented on May 29, 2024 1

@lightsofapollo There has a lot of changes in my commit, which branch should be merged? maybe create a new branch?

from joi-to-json-schema.

HugoHeneault avatar HugoHeneault commented on May 29, 2024

So looking deeper to this issue, I figured out that, as said on joi v16 release notes:

joi v16.0.0 is a massive release with many changes to every corner of the module and its extensions. The entire code base has been rewritten with many new features and core components.

Updating joi-to-json-schema to work with this new joi version will be more than just using Joi.isSchema(). I'm not sure I'll have enough time to go through all the fixes so I might downgrade my joi version for now.

If anyone need some help for doing the upgrade I could give a hand but not carry all by myself 😦

from joi-to-json-schema.

yeongjet avatar yeongjet commented on May 29, 2024

Hope this project support the joi v16.

from joi-to-json-schema.

BrianSo avatar BrianSo commented on May 29, 2024

@yeongjet I tried your repo and it is working, I really hope you could contribute your work to the repo.

But I found that you're changing all files to typescript and the commit message is update. Could you explain whether you have done any thing other than setting up a typescript development environment in the first update commit?

And did you remove any previous test cases?

from joi-to-json-schema.

yeongjet avatar yeongjet commented on May 29, 2024

@BrianSo No, in order to make these test cases running in jest, I have to make syntax modification, there's no difference in fundamental. Except these, the most noteworthy in my commit is remapping the fields and make them works in original logic.

from joi-to-json-schema.

lightsofapollo avatar lightsofapollo commented on May 29, 2024

@yeongjet Yes! This repo is in maintenance mode but I'd love some contributions particularly in typescript/new joi direction.

from joi-to-json-schema.

simlu avatar simlu commented on May 29, 2024

We'd love to see joi 1.16 supported as well

from joi-to-json-schema.

vgjenks avatar vgjenks commented on May 29, 2024

@lightsofapollo @yeongjet - any chance this will get merged? This is a package I really need, and it's completely broken in latest Joi. Looks like no movement in over a year. :( Dead project?

from joi-to-json-schema.

simlu avatar simlu commented on May 29, 2024

@vgjenks We now use https://www.npmjs.com/package/joi-to-json - works really well for our use case

Edit: Here is the corresponding github repo https://github.com/kenspirit/joi-to-json

from joi-to-json-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.