Comments (3)
sugyan
commented on July 4, 2024
1
Thanks for your contribution!
I have some comments...
- Please use
gofmt. Align the indents and use tab instead of spaces. - Since "Flex messages" and "LIFF" are different functions, we want pull-requests to be separated.
- BTW, I was preparing for flex messages... https://github.com/sugyan/line-bot-sdk-go/tree/flex-messages
.gitignorefor files not related to Go language should be set by each developer ingit config --global core.excludesfileetc. It should not be included in pull-request.
from line-bot-sdk-go.
justdomepaul
commented on July 4, 2024
1
Thanks for your feedback!
I will handle some point.
- fmt all changed go file
- new two branch to separeate "Flex Messages" and "LIFF" function to different PR.
- recovery origin .gitignore file
ps. I think your "Flex Messages" solution is better than my solution. It is a good point to solve complex struct of "Flex Messages".
from line-bot-sdk-go.
sugyan
commented on July 4, 2024
This has been updated by #89, so I close it.
from line-bot-sdk-go.
Related Issues (20)
- Refusing to allow a Personal Access Token to create or update workflow HOT 6
- Add properties for Manage LIFF APIs
- Verify channel access token method HOT 6
- Get content transcoding status and a preview image HOT 1
- @All in the mention property of the webhooks
- Add UnmarshalJSON method to Template HOT 1
- Bug Report: invalid signature in localhost via tunnel (ngrok or localhost.run) HOT 6
- Flex message update 4 HOT 1
- Rich Menu Batch Control HOT 1
- Seeking Alternative Solution for Code Quality Analysis - Golint Deprecated HOT 1
- Stateless channel access token API HOT 1
- Quote Message HOT 1
- Start to implement code generation based on LINE OpenAPI specification HOT 1
- Bump up minor version automatically or semi-automatically
- Renovate + open PR to add generated code automatically
- Cannot call a second function after call a first function. (version 8) HOT 3
- [ERR] tls: failed to verify certificate: x509: certificate signed by unknown authority HOT 1
- Concurrent goroutine and WithRetryKey() Usage Leads to Request Discrepancies HOT 3
- Enable to create Messaging API channel in developer console HOT 2
- Easy way to add emoji to text message HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from line-bot-sdk-go.