GithubHelp home page GithubHelp logo

New LIFF API PR about line-bot-sdk-go HOT 3 CLOSED

line avatar line commented on June 16, 2024
New LIFF API PR

from line-bot-sdk-go.

Comments (3)

sugyan avatar sugyan commented on June 16, 2024 1

Thanks for updating your pull-request.
It seems almost good, but I have some comments for improvement.

  1. liff.go has some problems with comments and field names.
linebot/liff.go:26:6: exported type LIFFAPP should have comment or be unexported
linebot/liff.go:31:6: exported type ViewRequest should have comment or be unexported
linebot/liff.go:35:6: exported type View should have comment or be unexported
linebot/liff.go:37:2: struct field Url should be URL
linebot/liff.go:40:1: comment on exported method Client.GetLIFF should be of the form "GetLIFF ..."
linebot/liff.go:71:1: comment on exported method Client.AddLIFF should be of the form "AddLIFF ..."
linebot/liff.go:118:1: comment on exported method Client.UpdateLIFFCall should be of the form "UpdateLIFFCall ..."
linebot/liff.go:119:38: method parameter liffId should be liffID
linebot/liff.go:146:3: struct field Url should be URL
linebot/liff.go:171:1: comment on exported method Client.DeleteLIFFCall should be of the form "DeleteLIFFCall ..."
linebot/liff.go:172:38: method parameter liffId should be liffID

please install and run golint (golang.org/x/lint/golint) and check outputs.

  1. method name has no consistency.
    I think func (client *Client) UpdateLIFFCall and func (client *Client) DeleteLIFFCall should be named UpdateLIFF and DeleteLIFF, which shouldn't include Call.

and...

This pull-request seems to contain many commits unrelated to LIFF.
I'd be happy if you make different pull-request which only include relevant changes as separate branches.

Did you sign the ICLA? https://feedback.line.me/enquete/public/919-h9Yqmr1u
Please submit that if you didn't submit yet.

from line-bot-sdk-go.

justdomepaul avatar justdomepaul commented on June 16, 2024 1

#90

@sugyan

I separate a new alone "liff api" branch, golint file, and change func name to your suggestion.

Please code review and merge, thanks.

ps. I have applied ICLA recently.

from line-bot-sdk-go.

justdomepaul avatar justdomepaul commented on June 16, 2024

Ok, I will modify these issue, rebase commit and push latest version.

from line-bot-sdk-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.