GithubHelp home page GithubHelp logo

Run doctests in CI about xilem HOT 2 CLOSED

DJMcNab avatar DJMcNab commented on August 22, 2024
Run doctests in CI

from xilem.

Comments (2)

matta avatar matta commented on August 22, 2024

I've sent a PR but I'm confused about @DJMcNab's comment:

This issue also applies to Vello.

..because linebender/vello@91c945a seems to have set up doctests correctly and they're still running in vello CI.

It does raise the question: should xilem follow suit and run doc tests on just a single platform? Currently they run quickly so I'm not sure the how to weigh the compute cost vs. potential for bit rot if nobody notices that a platform specific doctest manifests.

from xilem.

DJMcNab avatar DJMcNab commented on August 22, 2024

Thanks for making that PR, will review it now!

I don't think that the linked PR/commit touched doc tests. The commit message is inaccurate.

That PR checks that the documentation builds correctly, but it isn't actually running the doc tests. Indeed, in that PR the cargo test runs are what are running the doc tests.

from xilem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.