GithubHelp home page GithubHelp logo

Comments (2)

cmungall avatar cmungall commented on May 30, 2024

There is a flag here, inject_metadata, default True:

https://github.com/linkml/linkml-runtime/blob/a1d2c0c728ed4d260869c877a033e2827e5173ef/linkml_runtime/utils/schemaview.py#L150-L183

But this may have some side effects if this is not stored - schemaview works with an import closure by default and the semantics of some slots may be relative to the containing schema; e.g:

https://github.com/linkml/linkml-runtime/blob/a1d2c0c728ed4d260869c877a033e2827e5173ef/linkml_runtime/utils/schemaview.py#L787

I think this should be redesigned such we don't rely on injection but instead on a separate map of (unique) elements to schemas; this is essentially what is done here: https://github.com/linkml/linkml-runtime/blob/a1d2c0c728ed4d260869c877a033e2827e5173ef/linkml_runtime/utils/schemaview.py#L781-L788

so I think we should be fine if we modify the logic here

But we will want lots more tests here

in the interim I would just add something here: https://github.com/linkml/linkml-runtime/blob/main/linkml_runtime/utils/schema_as_dict.py

You will likely want to use this anyway, to avoid the repetition of name as both a key and a slot

from schemasheets.

sierra-moxon avatar sierra-moxon commented on May 30, 2024

it looks like schema_as_dict is working now, @putmantime? closing for now; please reopen if this is still an issue?

from schemasheets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.