GithubHelp home page GithubHelp logo

Comments (7)

zccrs avatar zccrs commented on June 12, 2024 1

@Yanhao @mitya57 8d32577

from dtkcore.

Yanhao avatar Yanhao commented on June 12, 2024

@zccrs

from dtkcore.

zccrs avatar zccrs commented on June 12, 2024
  • MKSPECS_INSTALL_DIR=$${QT_HOST_DATA}/mkspecs
  • MKSPECS_INSTALL_DIR=$$[QT_HOST_DATA]/mkspecs

没看出来这俩有啥改动呀

from dtkcore.

Yanhao avatar Yanhao commented on June 12, 2024

好像是没改动,不知道diff是怎么计算差异的,不过这不重要 :p

from dtkcore.

mitya57 avatar mitya57 commented on June 12, 2024

好像是没改动,不知道diff是怎么计算差异的,不过这不重要 :p

This means that you cannot see the difference in the changed lines, right?

However there is difference: I changed curly brackets {...} to square brackets [...].

Square brackets allow you to access qmake built-in variables like QT_HOST_DATA or QT_INSTALL_ARCHDATA. See the documentation: https://doc.qt.io/qt-5/qmake-language.html#accessing-qmake-properties.

So your pull request #11 does not actually fix cross-compilation on Debian. To get it working properly, you should use the built-in variables (e.g. $$[QT_INSTALL_ARCHDATA]) instead of calling qmake as subprocess.

from dtkcore.

BLumia avatar BLumia commented on June 12, 2024

So your pull request #11 does not actually fix cross-compilation on Debian. To get it working properly, you should use the built-in variables (e.g. $$[QT_INSTALL_ARCHDATA]) instead of calling qmake as subprocess.

@zccrs

from dtkcore.

mitya57 avatar mitya57 commented on June 12, 2024

Thanks!

from dtkcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.