GithubHelp home page GithubHelp logo

Comments (17)

tibbe avatar tibbe commented on July 28, 2024 1

I guess the new config UI needs to have a separate fields for the API token, so that Heimdall can correctly compose the URLs it needs (i.e. the URL field would still be the api.php base URL).

from heimdall-apps.

tibbe avatar tibbe commented on July 28, 2024 1

Finally managed to make it work by using http://pihole:80/admin/api.php. Note that "pihole" is the container name and thus the name on the internal docker network. Port 80 is the internal container port of the docker container, not the port exposed on the host.

from heimdall-apps.

antoniodourado avatar antoniodourado commented on July 28, 2024

I'm having the same issue. Waiting for the update.
Browser console is displaying the following and probably is for the same reason mentioned by @Mask3007 :
image

Also, how do I update Heimdall to the latest version after it gets fixed? I'm runing it in a container with docker compose.

from heimdall-apps.

wez avatar wez commented on July 28, 2024

FWIW, I worked around this by having my traefik proxy redirect the broken URL:

middlewares:
    pihole-stats-redirect:
      # Workaround for https://github.com/linuxserver/Heimdall/issues/1083
      redirectRegex:
        regex: "^https://pihole.local/stats/api.php$"
        replacement: "https://pihole.local/admin/api.php?summaryRaw&auth=TOKEN"

and add pihole-stats-redirect to the list of middlewares for my pihole service.

I have the config URL explicitly set to https://pihole.local/stats in heimdall (which in turn implicitly appends /api.php when making the request).

This effectively allows unauthenticated access to just the stats page, via the proxy, which seems reasonable to me.

from heimdall-apps.

rmatte avatar rmatte commented on July 28, 2024

I don't think that the config UI needs a separate field for an API token, because different apps could pass in the token with different names / identifiers for it. I just think it would be nice if the config field could accept a URL with the relevant options in a standard format like...

http://172.17.0.4:80/admin/api.php?summary&auth=my_api_token

Where my_api_token is the token provided by pi-hole. That way the config field would be much more flexible. The field doesn't currently seem to allow for that just because of how the Pihole.php is parsing the data from that field.

from heimdall-apps.

rmatte avatar rmatte commented on July 28, 2024

I'm also not really sure how this ended up with an enhancement label when the entire stats feature for pi-hole is effectively broken at this point. Just saying.

from heimdall-apps.

keriati avatar keriati commented on July 28, 2024

After triggering an Update of the App List it should be possible now to add Pi-hole with an api key.
Note: probably editing of the old Pi-hole entries will not work as they are now missing an api key from the db.

from heimdall-apps.

Xaositek avatar Xaositek commented on July 28, 2024

image

Running Heimdall 2.5.5 within Docker on unRAID and after updating the Application list, I don't see the new API field yet.

image

from heimdall-apps.

keriati avatar keriati commented on July 28, 2024

I would try to refresh the page, I dunno why, for me it just showed up at some point. Maybe some cache is keeping the old version...

from heimdall-apps.

Xaositek avatar Xaositek commented on July 28, 2024

I would try to refresh the page, I dunno why, for me it just showed up at some point. Maybe some cache is keeping the old version...

At this point I've tried on my iPad, iPhone, MacBook, and Windows 11 VM. Tried Safari, Chrome, and Firefox. I don't think it's cache or browser at this point. I've also restarted the Docker container twice.

from heimdall-apps.

rmatte avatar rmatte commented on July 28, 2024

I would try to refresh the page, I dunno why, for me it just showed up at some point. Maybe some cache is keeping the old version...

At this point I've tried on my iPad, iPhone, MacBook, and Windows 11 VM. Tried Safari, Chrome, and Firefox. I don't think it's cache or browser at this point. I've also restarted the Docker container twice.

For me I had to remove the Pi-hole app from heimdall dashboard and re-create it. Not sure if you've done that or not but just mentioning it. Maybe your app list update didn't complete or something?

from heimdall-apps.

Xaositek avatar Xaositek commented on July 28, 2024

I would try to refresh the page, I dunno why, for me it just showed up at some point. Maybe some cache is keeping the old version...

At this point I've tried on my iPad, iPhone, MacBook, and Windows 11 VM. Tried Safari, Chrome, and Firefox. I don't think it's cache or browser at this point. I've also restarted the Docker container twice.

For me I had to remove the Pi-hole app from heimdall dashboard and re-create it. Not sure if you've done that or not but just mentioning it. Maybe your app list update didn't complete or something?

At this point I deleted my three links to different Pi-Hole servers I have, removed them from my trash bin, restarted the Docker container again, re-ran the Application list update and still nothing.

from heimdall-apps.

Xaositek avatar Xaositek commented on July 28, 2024

okay so just destroyed the entire Docker image and rebuilt it - problem is solved now.

from heimdall-apps.

tibbe avatar tibbe commented on July 28, 2024

I still can't figure out what URL to use. Since my docker container has the name "pihole" and runs on port 8081 I tried http://pihole:8081/admin/api.php?summaryRaw&auth=<token> and various other combinations of query parameters I could think of. What's the right URL to use?

from heimdall-apps.

rmatte avatar rmatte commented on July 28, 2024

I still can't figure out what URL to use. Since my docker container has the name "pihole" and runs on port 8081 I tried http://pihole:8081/admin/api.php?summaryRaw&auth=<token> and various other combinations of query parameters I could think of. What's the right URL to use?

When you're adding Pi-hole to heimdall make sure you have the application type selected as Pi-hole, then you'll have a "Config (Optional)" section at the bottom. Set the URL to http://<pi_hole_ip_address>:<pihole_port>/admin/api.php and put the API key in the "API key" field right next to that. The main URL for actually visiting the Pi-hole page is configured above that Config section under the main URL field and should be set to http://<pi_hole_ip_address>:<pihole_port>/admin/login.php

from heimdall-apps.

tibbe avatar tibbe commented on July 28, 2024

I still can't figure out what URL to use. Since my docker container has the name "pihole" and runs on port 8081 I tried http://pihole:8081/admin/api.php?summaryRaw&auth=<token> and various other combinations of query parameters I could think of. What's the right URL to use?

When you're adding Pi-hole to heimdall make sure you have the application type selected as Pi-hole, then you'll have a "Config (Optional)" section at the bottom. Set the URL to http://<pi_hole_ip_address>:<pihole_port>/admin/api.php and put the API key in the "API key" field right next to that. The main URL for actually visiting the Pi-hole page is configured above that Config section under the main URL field and should be set to http://<pi_hole_ip_address>:<pihole_port>/admin/login.php

Is the port 1010 different from the standard http port or do both urls have the same port?

from heimdall-apps.

rmatte avatar rmatte commented on July 28, 2024

I still can't figure out what URL to use. Since my docker container has the name "pihole" and runs on port 8081 I tried http://pihole:8081/admin/api.php?summaryRaw&auth=<token> and various other combinations of query parameters I could think of. What's the right URL to use?

When you're adding Pi-hole to heimdall make sure you have the application type selected as Pi-hole, then you'll have a "Config (Optional)" section at the bottom. Set the URL to http://<pi_hole_ip_address>:<pihole_port>/admin/api.php and put the API key in the "API key" field right next to that. The main URL for actually visiting the Pi-hole page is configured above that Config section under the main URL field and should be set to http://<pi_hole_ip_address>:<pihole_port>/admin/login.php

Is the port 1010 different from the standard http port or do both urls have the same port?

It entirely depends on how you set it up. I have mine running on port 1010 for the main http UI so that's what I use.

from heimdall-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.