Comments (5)
The same case at all themes.
I using preview look.
from darkness.
I would disagree and agree with your statement that inversion is a bad idea.
It's a great place to start, but not a complete solution, that's why we have this plugin, where it's possible to fix the mistakes that may occur when inverting everything.
If you look through the source code you will see that it's not just inversion, far from it.
I fixed the color picker on Google (http://puu.sh/yvhLb/8ebe4603c2.jpg) and I don't understand what the problem is, what content is inverted that shouldn't be? videos, images, gifs? Please send us a screenshot.
from darkness.
I agree with @theme1256 here.
Inversion has it's problems, sure. However, the alternative is manually trying to style all DOM elements in a page to have a dark color. What usually happens is that:
- You never get 100% coverage (all the pages and all dialogs seen by all users of a website)
- The site often gets new UI elements which are then bright.
So instead of occasional bugs like the one you described (the lesser of two evils), you get screaming white in the middle of a dark page, which is worse IMHO.
@theme1256 - thanks for the fix. I'm closing this ticket for now.
@planet17 - if you encounter any other inversions issues, please open another ticket, or push a fix to the codebase (pull requests are more than welcome!)
from darkness.
@theme1256 Yeah, I had mean only color picker. On my screen it had been selected blue color, but how you can see display orange.
I didnt know, why I had seen not fixed color. Just maybe I looks into "preview version".
from darkness.
@theme1256
About inversion in any way, I just had said my opinion.
I think my knowledge of CSS - worse. So I just suggested it.
Thanks for tell me why I can be wrong!
from darkness.
Related Issues (20)
- Darkness vanishes as you scroll through Twitter HOT 1
- messenger.com new version breaks the themes HOT 4
- suggestion: visible elements HOT 1
- Elements on facebook.com not styled correctly HOT 1
- Firefox Extension Unavailable HOT 3
- The Upgrade Section
- negative trello image HOT 2
- Publish to Microsoft Edge Add-ons website HOT 1
- Poor support with github dark themes
- Messenger - messages have light gray background with medium gray text (unreadable) HOT 7
- Ms HOT 1
- Ms. HOT 1
- Enable extension in TikTok Web
- Darkness theme not applied to scrollbar on YouTube
- suggestion www.qwant.com
- Chrome extension stops working in random fashion
- Darkness icon gone and doesn't work anymore HOT 1
- "other actions" key not visible on Google Contacts website HOT 1
- Colors displayed in Google Calendar's color selection are different
- Google Photos: Action buttons covered by a solid color
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from darkness.