Matching Regex for Non Root Level Site Match about darkness

[liorgrossman]

Yeah. Currently the code in background.js only compares "hostRegExp" with the current URL "hostname". This doesn't include the path:

var urlParts = parseUrl(url);
...
if (urlParts.hostname.match(CONFIG.sites[siteKey].hostRegExp)) {

You could theoritically add code such as:

if (urlParts.path.match(CONFIG.sites[siteKey].pathRegExp)) {

to test the path.

However, I think skinning any website that contains /tfs/ in the path is a bit too risky. I'm sure few websites that are not Team Foundation Server have /tfs/ in the path, and we would accidentally skin them.
Is there any other way of detection TFS websites? (I'm not familiar with the product)

[sheldonhull]

Thanks for the insight. To narrow /tfs/ further could be done by /tfs/DefaultCollection/` as that's unlikely to be used elsewhere.

That's helpful to know.

[liorgrossman]

Yeah, limiting it to run only if path equals /tfs/DefaultCollection/ seems reasonable.

You could start by adding path matching to background.js:

if (CONFIG.sites[siteKey].pathRegExp && urlParts.path.match(CONFIG.sites[siteKey].pathRegExp)) {

This could run even before matching the hostname.

then adding "pathRegExp": "\/tfs\/DefaultCollection\/" to the TFS site (under config.js)