GithubHelp home page GithubHelp logo

Comments (4)

christianechevarria avatar christianechevarria commented on May 27, 2024

Removed in 6f2383b

Briefly added a check for mutation.MOD_ACTIVATION before mutating the new node but it didn't seem worth the performance cost

from carrot.

christianechevarria avatar christianechevarria commented on May 27, 2024

@dan-ryan After some more testing, confirmed that this makes converging on a solution more difficult (which makes sense)

I'm thinking about reintroducing this but adding a flag to overwrite the default behavior.

Any thoughts?

from carrot.

dan-ryan avatar dan-ryan commented on May 27, 2024

"but it didn't seem worth the performance cost"
One check hurt the performance that much?

Otherwise could just make it clear in the docs that there is this side effect.

from carrot.

christianechevarria avatar christianechevarria commented on May 27, 2024

Restored it in f27e594

Just ended up adding a randomActivation property to the ADD_NODE object and a check to see if it's set to true (it is by default, but can be overwritten)

Closing for now

from carrot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.