GithubHelp home page GithubHelp logo

Comments (8)

MaximusHaximus avatar MaximusHaximus commented on July 2, 2024 2

Also, both isomorphic and node packages patch globalthis.fetch. Do we need this given fetch was added to Node 18, and is stable as of Node 21 or do you want to support older versions than this? I expect this might create issues as other packages also patch globalthis.fetch. In particular, I know Next.js patches it, which might be quite commonly used with the lit sdk.

Hey all, just a brief update:

  1. We're replacing our own internal polyfilling of fetch with cross-fetch to ensure it is handled properly across multiple environments and versions of node.
  2. We're removing the ipfs-http-client dependency entirely, as it was only used by one convenience method and the amount of code behind it is quite huge, even apart from it being deprecated :). This issue will be resolved by #427 . Sorry about the delay on getting this fixed up -- it turned into a bit of a rabbit hole -- and thanks so much for your patience 💖 .

from js-sdk.

0x62 avatar 0x62 commented on July 2, 2024

I'm also hitting this issue with a Remix app, there is also an open issue on the ipfs-utils library for it. ipfs-http-client has been deprecated for a while, so won't be updated to fix this anytime soon.

Can Lit move to something like https://github.com/ipfs/helia-verified-fetch instead?

from js-sdk.

jrhe avatar jrhe commented on July 2, 2024

Spent a fair bit of time looking at this today as it's blocking me developing anything with lit.

ipfs-http-client is just used by the encryptToIpfs method. The decryptFromIpfs uses vanilla fetch already, so it might make sense use fetch for encrypt too and remove a dependency. If a client library is desired js-kubo-rpc-client appears to be a drop in replacement, but it suffers the same issue, so it would need changing.

Encrypt uses Infura's gateway and decrypt uses pinata's gateway - is there any particular reason for this? It might be best to allow the user to specify the gateway and params. If a gateway is down they may want to use another. Case in point, Infura are not currently issuing new API keys for it's IPFS gateway (Temporary limits on new IPFS Keys).

If js-kubo-rpc-client'is used, the encrypt/decrypt methods could be adapted to accept a client object as a parameter, and the encrypt/decrypt methods could call that.

from js-sdk.

Ansonhkg avatar Ansonhkg commented on July 2, 2024

@jrhe @0x62 We will have this fixed in the next day or 2, @MaximusHaximus has been working on it! :)

from js-sdk.

johnnynanjiang avatar johnnynanjiang commented on July 2, 2024

Another similar issue @Ansonhkg @MaximusHaximus

yarn nx run react:serve failed with error [react]: > NX Unable to resolve @nx/web:dev-server.

from js-sdk.

jrhe avatar jrhe commented on July 2, 2024

Also, both isomorphic and node packages patch globalthis.fetch. Do we need this given fetch was added to Node 18, and is stable as of Node 21 or do you want to support older versions than this? I expect this might create issues as other packages also patch globalthis.fetch. In particular, I know Next.js patches it, which might be quite commonly used with the lit sdk.

from js-sdk.

Ansonhkg avatar Ansonhkg commented on July 2, 2024

Hey @johnnynanjiang @jrhe @jwkim960315 we have just published v5.0.0. Let us know if you're still seeing the above issues! :) #432

from js-sdk.

johnnynanjiang avatar johnnynanjiang commented on July 2, 2024

@Ansonhkg the following 2 still not working, I expect to run test apps to see how Lit Protocol works, but they seem to be low priority. If they don't work, how builders expect to see how Lit Protocol works?

// react
yarn nx run react:serve

error
 >  NX   Unable to resolve @nx/web:dev-server.

and

// nodejs
yarn nx run nodejs:serve

error
Cannot find module '../Lit'

from js-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.