GithubHelp home page GithubHelp logo

Comments (5)

joshfester avatar joshfester commented on June 9, 2024 1

Thanks @jessuppi

I've never run into any scaling issues with access logging, but it does make sense that disabling it would increase performance. It would be very interesting to see a benchmark comparing logs vs no logs

One argument for enabling the logs is monitoring tools. I ran into this issue because I was testing out Nginx Amplify. It not only requires the access logs, it also requires writing additional data to the logs. I believe this is pretty common -- at first glance it looks like this is how Signoz monitors Nginx as well.

Another option is passing the logs to syslog rather than writing directly to a file. I swear I saw some Nginx docs implying that this was better for performance, but I can't find a link. It's possible that this is a good middle ground.

Overall I'd lean towards using access logs for monitoring. However, I still haven't narrowed my search for the best monitoring solution. Would love to hear your thoughts on that if you have any

from slickstack.

jessuppi avatar jessuppi commented on June 9, 2024 1

Great thanks for the specific examples @joshfester

I've been wanting to hardcode enable access_log for the last few years, just was hoping someone else would come by and sort of confirm my opinions on this publicly. I have some fairly high traffic clients using SlickStack with access logging enabled and haven't noticed any issues, I think for usability it makes much more sense to keep it enabled.

Plus, we just recently added support for cloudflare.conf and real IP tracking anyways.

Ref: #198

Another option is passing the logs to syslog rather than writing directly to a file. I swear I saw some Nginx docs implying that this was better for performance, but I can't find a link. It's possible that this is a good middle ground.

That's interesting, I've never heard that before. I wonder why. Well, to keep things clean and organized I think best to keep the logs a bit separate from each other when appropriate so let's keep as-is for now. Thanks!

Re: monitoring prob best to discuss on the forums or Discord

from slickstack.

jessuppi avatar jessuppi commented on June 9, 2024

You are correct @joshfester

There are still some things like this floating around SlickStack, because I'm not sure about a few features being hardcoded or not, or what the best default setting should be. What are your thoughts re: access logging?

In the past the opinion has been it wastes CPU esp. during high traffic. However I'm not sure how serious that is, because I haven't noticed major issues with it in most cases.

from slickstack.

jessuppi avatar jessuppi commented on June 9, 2024

Ref: e0f37ff

from slickstack.

jessuppi avatar jessuppi commented on June 9, 2024

Ref: 8bb62da

from slickstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.