Comments (12)
Ah yes, I noticed that Loki seems to have disappeared 😕 The Mac branch is working and I'm basically just collecting bugs but so far not to many have come up (currently just one open todo), so it should be fine to merge. When I have some time, I will try to rebase it on top of this repository.
from sunshine.
@ReenigneArcher I successfully rebased on nightly
without any major issue and I'm in the process to prepare the PR. However, there is one question that I'm currently facing: Do you want me to squash the 30-40 commits I currently have or can I keep them around? I strongly prefer the latter option as it will probably make it easier to understand in the future why certain decisions were made the way they are.
from sunshine.
@abusse would you be interested in doing a PR to this repo for Mac support?
It would be a somewhat manual process, and I apologize for that, as this is an import (not a fork) of Loki's repo.
Not sure the current state of your branch. If it's working, even if just experimentally I think it would be nice to include in our next release.
from sunshine.
Ah yes, I noticed that Loki seems to have disappeared 😕 The Mac branch is working and I'm basically just collecting bugs but so far not to many have come up (currently just one open todo), so it should be fine to merge. When I have some time, I will try to rebase it on top of this repository.
Amazing! Even though I don't use mac personally, definitely appreciate all your work!
Whenever you get to it, rebase on the nightly
branch. If you don't it's not a big deal but the first PR check will fail and ask you to change it.
from sunshine.
@ReenigneArcher I successfully rebased on
nightly
without any major issue and I'm in the process to prepare the PR. However, there is one question that I'm currently facing: Do you want me to squash the 30-40 commits I currently have or can I keep them around? I strongly prefer the latter option as it will probably make it easier to understand in the future why certain decisions were made the way they are.
That's awesome! I have no problem with either method. If you prefer to have all of the original commits that is fine with me. I don't know how much trouble that would be to be honest.
from sunshine.
@abusse Had a peek at the rebase... trying to prepare myself for what I'll need to update in the CI workflow. Looking good!
One question, can the apps_macos.json have Desktop and Steam BigPicture added similar to the windows and linux files? I guess technically Desktop is not in the windows file, but still appears in clients.
Also, any ideas for packaging? I found this, but to be honest I am not an expert on cmake. https://cmake.org/cmake/help/latest/cpack_gen/dmg.html
from sunshine.
@ReenigneArcher saw your additional comment just now after submitting the pull request 😞
We can probably add that, but so far the support only includes streaming the entire desktop. Streaming a specific window should not be to hard, but requires some refactoring as I hadn't considered that so far. Also lunching a different application would be something I have to look into.
Regarding the packaging, at the moment, my strategy would be to have a Port or Brew file. I was already looking into a Github flow to have automatic builds but back then Github didn't have the latest MacOS version as build host, which would have been required. But that would also only result in a CLI application. We would need a little bit more effort to have an actual App bundle. So far, I only have done CLI Applications for MacOS, so this would also need some more work from my side.
I would suggest once my pull request is merged, we create tickets and I (or other volunteers) can then work on them and keep track of the progress.
from sunshine.
@ReenigneArcher saw your additional comment just now after submitting the pull request 😞
We can probably add that, but so far the support only includes streaming the entire desktop. Streaming a specific window should not be to hard, but requires some refactoring as I hadn't considered that so far. Also lunching a different application would be something I have to look into.
Regarding the packaging, at the moment, my strategy would be to have a Port or Brew file. I was already looking into a Github flow to have automatic builds but back then Github didn't have the latest MacOS version as build host, which would have been required. But that would also only result in a CLI application. We would need a little bit more effort to have an actual App bundle. So far, I only have done CLI Applications for MacOS, so this would also need some more work from my side.
I would suggest once my pull request is merged, we create tickets and I (or other volunteers) can then work on them and keep track of the progress.
Sounds good. And I agree, this is a great first step, we can improve over time! I am running the build now to make sure nothing breaks on linux/windows side.
from sunshine.
@ReenigneArcher Can we have a label os:macOS
(and have this ticket the first to tag)? So I can easily filter once the issues for the macOS port start to role in.
from sunshine.
@ReenigneArcher Can we have a label
os:macOS
(and have this ticket the first to tag)? So I can easily filter once the issues for the macOS port start to role in.
Yes, absolutely. I just added those labels because I wanted to label all the Arch Linux issues, haha.
from sunshine.
@abusse I added the label for Mac. Also would you be interested in being on the org team? We could use someone with your experience level. If not, no worries. Also we have a discord, might be easier to discuss development topics there if you are on discord. https://sunshinestream.github.io/discord_join/
from sunshine.
This feature has been added and will be available in the next release.
from sunshine.
Related Issues (20)
- 0.23.0: CMake error when trying to build with tests disabled (-DBUILD_TESTS:BOOL=FALSE) HOT 5
- Stuttering and video decoding time shot up when waking up from standby. HOT 1
- Black screen when streaming. Error: GL: /build/sunshine/src/platform/linux/graphics.cpp:570: [00000502] HOT 11
- [Win] Service not starting if temp is on another drive HOT 10
- Scaling issues on strange resolutions and how to fix them.
- Wrong setcap command in displayed error message on home screen
- How can I get client's information? or whether the client connected or not? HOT 1
- Web interface claims there is a new version, while running latest available HOT 3
- Sound and Input working, screen seems to be stuck/frozen HOT 1
- Linux VAAPI Doesn't Work With AppImage or Flatpak HOT 17
- Duplicate "fastest" option in QuickSync Preset dropdown
- KMS Capture does not work on second monitor HOT 5
- Can't close the stream when running full desktop stream HOT 2
- M1 Sunshine is not Responding To Keyboard and Mouse Events from Android and PC Moonlight Apps HOT 2
- [Contains a solution.]Android Bluetooth mouse and keyboard remote access to PC, after a period of time, the mouse and keyboard input becomes unresponsive, but the screen transmission remains normal. HOT 1
- Wrong screen orientation on Steam Deck (Linux) using KMS HOT 4
- Streaming Desktop - Video appears pixelated HOT 2
- Incorrect keyboard mapping using a QWERTZ (de_DE) keyboard using an Android Moonlight client HOT 2
- Flatpak config migration breaks cover images HOT 2
- IddSampleDriver not detected in VM HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sunshine.