Comments (6)
Ah, you didn’t specify citgm. Yes, I’d need to publish a new release for that; I’ll do so today.
from tape.
That commit only affects tape’s tests, so publishing it wouldn’t help anything. Can you elaborate on what failure you’re seeing?
from tape.
We're seeing this:
# Subtest: async-bug
not ok 1 - should be equivalent
---
found:
- TAP version 13
- '# async-error'
- ok 1 before throw
- ok 2 should be strictly equal
- 'not ok 3 TypeError: Cannot read properties of null (reading ''length'')'
- ' ---'
- ' operator: error'
- ' stack: |-'
- ' TypeError: Cannot read properties of null (reading ''length'')'
- ' at myCode ($TEST/async-await/async-bug.js:$LINE:$COL)'
- ' at Test.myTest ($TEST/async-await/async-bug.js:$LINE:$COL)'
- ' ...'
- ''
- 1..3
- '# tests 3'
- '# pass 2'
- '# fail 1'
- ''
- ''
wanted:
- TAP version 13
- '# async-error'
- ok 1 before throw
- ok 2 should be strictly equal
- 'not ok 3 TypeError: Cannot read property ''length'' of null'
- ' ---'
- ' operator: error'
- ' stack: |-'
- ' TypeError: Cannot read property ''length'' of null'
- ' at myCode ($TEST/async-await/async-bug.js:$LINE:$COL)'
- ' at Test.myTest ($TEST/async-await/async-bug.js:$LINE:$COL)'
- ' ...'
- ''
- 1..3
- '# tests 3'
- '# pass 2'
- '# fail 1'
- ''
- ''
at:
line: 265
column: 11
file: test/async-await.js
stack: |
test/async-await.js:265:11
ChildProcess.<anonymous> (test/common.js:102:9)
ChildProcess.emit (node:events:390:28)
Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
source: |
t.same(stripFullStack(stdout), [
...
ok 2 - should be equivalent
ok 3 - should be equivalent
1..3
# failed 1 of 3 tests
When running citgm: https://github.com/nodejs/citgm. CITGM include the latest release of tape in the lookup.json as follows: https://github.com/nodejs/citgm/blob/b73cb0f07188307e0745e09b361c64610f37c5f8/lib/lookup.json#L500
Perhaps a new release needs to be created in github?
from tape.
Actual wait - most packages don’t publish their tests (altho all of mine do), can’t citgm be configured to look at the master branch on GitHub? I’d rather not publish a release that doesn’t include any actual changes.
from tape.
It can be done, are you suggesting that as a temporary solution for us until a new version is published?
from tape.
Certainly until then, yes - altho it might be nicer if there was some way to use the latest version of the package, and then git checkout origin/master test
or something?
from tape.
Related Issues (20)
- Automatically exclude node-specific packages from browser bundlers HOT 6
- How do I mock an image import? HOT 5
- Feature Request: --no-only flag for tape CLI command HOT 9
- t.comment adds multiple new lines for multi-line strings HOT 9
- Enhancement request: ESM version for testing apps that use custom ES Module Loaders HOT 2
- RFE: Document use with TypeScript HOT 4
- Cannot create a stream then load ESM test modules HOT 9
- Using typescript with esm leads to importOrRequire issue HOT 5
- Looking for a tap reporter HOT 4
- CLI accept multiple directories and execute in order HOT 2
- How do I run single test? HOT 1
- CLI options for IDE integrations. HOT 5
- tests seem to fail on windows. HOT 6
- `.only()` fails with asynchronous tests HOT 13
- Suggestion: Ignore pattern directly instead of pointing to a file? HOT 3
- Upgrade to TAP 14 - support for subtests, maybe indentation? HOT 1
- Tips on how to run a single test HOT 2
- t.true() should be exact. HOT 8
- Async: supported or not? Change docs? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tape.