Comments (2)
I am not sure I understand the problem. I thought vndr <pkg>
were supposed to download package to vendor directory, though I might remember wrong.
Do you have example repo where I could try that?
from vndr.
Sorry, I wasn't clear enough.
Consider a scenario:
Suppose I create a go dir, add some imports, then I perform vndr init
. This will install all the referenced imports in the vendor dir.
Now, I add another import say package 'A'.
I don't have 'A' on local file system yet. Now if I issue just vndr
, this will be successful.
Now, in such a situation, the compilation would fail obviously.
But, I was wondering if it was better to log the missing package as well.
Currently, in this workflow, we hit the following case in 'collectAllDeps' method.
if err != nil {
if strings.Contains(err.Error(), "cannot find package ") && dlFunc != nil {
ipkg, err = dlFunc(imp)
}
}
Here, dlfunc is nil, so we just end up ignoring the 'cannot find package' error.
from vndr.
Related Issues (20)
- cache cloned git repositories HOT 1
- Possible vendor.conf syntax to allow use of tags without downsides of retagging HOT 3
- There is three options
- vndr does not warn on all unused packages
- Add a guide to migrate from godeps HOT 2
- vndr command not found
- Dot imports (Ginkgo) are ignored HOT 1
- strict mode does not fail for "cannot find package" error HOT 2
- Does not cleanup vendoring not referenced by `vendor.conf` if it is used HOT 2
- Please tag a new release HOT 1
- Latest patches break older apps HOT 3
- vndr not download c files defined by cgo HOT 1
- Latest vndr picks up lots more stuff (due to .c file inclusion) HOT 2
- Vendoring standard packages
- tag a new release HOT 2
- Infinite loop when an invalid version/tag is defined HOT 3
- vndr erasing multiple dependencies on run HOT 1
- https://api.bitbucket.org/1.0/repositories/ww/goautoneg: 410 Gone HOT 5
- `vndr init` produces wrong `vendor.conf` for versioned packages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vndr.