Disabling `Update branch` button about 404-pagenotfound

[SpootyMcSpoot]

Any update here? I'd like to see the option of enforcing this without the button present. Devs can rebase on their local and push rather than use the button.

[mo-klue]

https://github.com/motakbiri/UpdateBranchRemover/

[lnfnunes]

@rsp we don't "disable" the button as you may be thinking, we just remove the check forcing branches to be up-to-date with master. Personally, I prefer to keep this ON, but as @luisfmsouza said, it adds some misunderstanding on novice people and difficult contributions with some kind of invisible contribute wall rule!

Settings 👇

So far, so good! We had no problems without this option 🙂

[lnfnunes]

@luisfmsouza I have a different opinion about this point. I like to enforce branches to be up-to-date with master always, so the "Update branch" button is just a try, exactly, to prevent asking people to do rebasing themselves.

Even though your print is showing a noisy, the master timeline is kept untouched and clean

How to garantee the PR is up-to-date with master and we are not loosing anything? I'm not sure if only in conflicted state this could happen...

Anyway, I'll change the settings and we can give it a try ✌️

[luisfmsouza]

Let's try it.

[rsp]

Sorry for an off-topic question but how have you managed to disable the 'Update branch' button? I was sure that it is impossible to disable it (see those comments).

[Bubesz]

@rsp we don't "disable" the button as you may be thinking, we just remove the check forcing branches to be up-to-date with master. Personally, I prefer to keep this ON, but as @luisfmsouza said, it adds some misunderstanding on novice people and difficult contributions with some kind of invisible contribute wall rule!

Settings 👇

So far, so good! We had no problems without this option 🙂

This was extremely valuable information for me! I'm glad you shared it! 👍

I added the "Require status checks to pass before merging" rule with the aforementioned "Require branches to be up to date before merging" rule at the beginning of a testing period. Because of the low intensity of coding (to main branch), we did not come across the "Update Branch" button for days and on one hand, I forgot I added such a rule, and more importantly,

I expected this button to rebase the PR HEAD branch onto the base branch but instead, it creates a merge commit. We use rebase everywhere, so we'd like to avoid merges. This way, we had to manually rebase our branches which was a headache. Currently, the update strategy of the Update Branch button cannot be configured. Actually, there is an issue related to this: isaacs/github#1419

[bgrosse-midokura]

I can't find this checkbox in Settings?

Edit: found it under Settings->Branches->Branch protection rules->Edit button

[lnfnunes]

Enabled it!