lob API returning 503 throws about lob-python

[UjjwalAyyangar]

@justmobilize Are you still experiencing this issue?

payload = resp.json() is only thrown when the status is 200, for 503 it raises APIError with appropriate message

[justmobilize]

Looking at code on master:

    def parse_response(self, resp):
        if resp.status_code == 504:
            raise error.APIConnectionError(resp.content or resp.reason,  # pragma: no cover
                                           resp.content, resp.status_code, resp)

        payload = resp.json()
        if resp.status_code == 200:
            return payload
        elif resp.status_code == 401:
            raise error.AuthenticationError(payload['error']['message'],
                                            resp.content, resp.status_code, resp)
        elif resp.status_code in [404, 422]:
            raise error.InvalidRequestError(payload['error']['message'],
                                            resp.content, resp.status_code, resp)
        else:  # pragma: no cover
            raise error.APIError(payload['error']['message'], resp.content, resp.status_code, resp)

it parses before the resp.status_code is evaluated. I would imagine it better to handle the 503 in the same way as the 504 since those are both from the web server, not the application

[UjjwalAyyangar]

Agreed.
@ami is anyone working on this?
If no, then I can send in a pull request to fix this.

[pdufour]

Closed due to inactivity, if it is still an issue please re-open. Thank you!

[justmobilize]

This is still an issue @pdufour