localforage.min.js not loading through require.js? about localforage

[pwoolcoc]

I tried something right after I posted this. If I set 'localforage' as an alias to localforage.min in my requirejs config, it works fine:

requirejs.config({
    "baseUrl": "js/lib",
    "paths": {
        "app": "../app",
        "localforage": "localforage.min"
    }
});

requirejs(["app/main"]);

app/main.js

define(["localforage"], function(lf) {
    console.log(lf); // => Object { INDEXEDDB="asyncStorage", LOCALSTORAGE="localStorageWrapper", WEBSQL="webSQLStorage", more...} main.js (line 3)
});

[magalhas]

Not sure, but since you're specifying .min requirejs may assume that .min is the file extension. Try require(['localforage.min.js'], though the config approach is a better one imo.

[magalhas]

Oh sorry, didn't notice that your console.log was being executed. But this appears to be a requirejs bug and not a problem with localforage.

[tofumatt]

@jrburke Any chance you could fill me in on if this is a require bug/quirk or something I've done wrong? Does requiring localForage as "localforage.min" cause errors? Keep in mind if define is available localForage does:

define('localforage', function() {
    return localForage;
});

as seen here.

[jrburke]

@tofumatt it is best if the define calls are anonymous in source form, so just define(function(){.... That will allow 'localforage.min' references to work.

In the larger picture, I also suggest for consumers of this lib that are using modules to use 'localforage' as the ID as that plays well with any other library that might want the same (they will just ask for 'localforage' anyway, will not know about if minified), and if a minified version is wanted, use a paths config, as the second comment does, to point to that minified version.

And going a step further, I would not use the minified version in source form in a project: I suggest using the non-minified forms in source, then rely on an r.js build step to do any minifications. This allows better debugging if you need to step into the source of a dependency, and the whole project minification will lead to better results over just specific files being minified.

But back to the more immediate question, an anonymous define() call is best practice. More details here.

[magalhas]

As said above, an anonimous define will fix the issue. I'll make a PR when I have some time if no one dibbs on that.

[tofumatt]

Works for me.