babel-plugin-lodash and babel-plugin-transform-object-rest-spread can cause an error when used together about babel-plugin-lodash

[jdalton]

Turns out a more robust check was easy after all. 4a9f946

[jdalton]

So the fix I have isn't super. It's just more restrictive. Ideally we'd know that the keys referenced in the helper code isn't the keys of the module but that would require a bit more inspection and I'd like to keep things simple for now.

[not-an-aardvark]

Thanks for the fix.

I remember from messing around with babel plugins in the past that babel's plugin API exposes a generateUidIdentifier function to avoid conflicts with local variables. Would that be applicable here?

[jdalton]

The identifiers are already generated with generateUidIdentifier by path.hub.file.addImport.

The issue isn't generated ids it's the the Babel helper's vars shadow those in an outer scope.
So I'd have to inspect and walk scopes (gross).

[not-an-aardvark]

Ah alright, that makes sense. Thanks for the clarification.

[jdalton]

Moved the checks into helper functions and applied them to all other areas. faea5c7.