GithubHelp home page GithubHelp logo

Comments (12)

jdalton avatar jdalton commented on May 4, 2024

/cc @breakbild, @DTrejo, @gonsfx, @jeffv, @JulesAU

from lodash.

jdalton avatar jdalton commented on May 4, 2024

/cc @cashlo, @fearphage, @kopious, @jou, @grignaak, @vkovalskiy

from lodash.

jdalton avatar jdalton commented on May 4, 2024

/cc @lazylester, @mattyurka, @russplaysguitar, @iwyg, @chadhietala, @jeremyckahn, @taybin, @ironchefpython

from lodash.

jeremyckahn avatar jeremyckahn commented on May 4, 2024

Awesome, thanks for the update. Great work on this! I tried swapping Underscore for Lo-Dash in Rekapi some time back and a few tests broke, but it looks like Lo-Dash has grown quite a bit. I will give it another shot.

from lodash.

jdalton avatar jdalton commented on May 4, 2024

@jeremyckahn

Great work on this!

Thanks!

I tried swapping Underscore for Lo-Dash in Rekapi some time back and a few tests broke, but it looks like Lo-Dash has grown quite a bit. I will give it another shot

While Lo-Dash is a drop-in replacement I have optimized and re-organized methods for common/tested/documented use. Some edge cases may slip through.

In this case the issue is _.pluck(this._actors, 'id') as Lo-Dash had optimized _.pluck to iterate over arrays-only (as thats the example and tested usage). I will re-evaluate the _.pluck optimization.

from lodash.

jeremyckahn avatar jeremyckahn commented on May 4, 2024

I will re-evaluate the _.pluck optimization.

Cool! I'll reconfigure Rekapi so that I can easily switch between Underscore and Lo-Dash for development. I think it's a good source of practical data points to test Lo-Dash against. This is a cool project and I'd love to help out!

from lodash.

taybin avatar taybin commented on May 4, 2024

Were these optimizations rejected from underscore? I'm a bit confused on why there's a rebranding of a fork without an attempt to get the improvements into the original project.

Although I am glad to see AMD support, which I know was declined by @jashkenas.

from lodash.

jdalton avatar jdalton commented on May 4, 2024

@taybin

I'm a bit confused on why there's a rebranding of a fork without an attempt to get the improvements into the original project.

Lo-Dash started as a reverted pull request.

Check out my reply to "What makes Lo-Dash different from Underscore"#28 (comment)

from lodash.

taybin avatar taybin commented on May 4, 2024

@jdalton Thanks. You might want to make the justification a little more prominent.

from lodash.

jdalton avatar jdalton commented on May 4, 2024

@jeremyckahn

Ok, all Rekapi unit tests pass with the edge version of Lo-Dash.

@taybin

Thanks. You might want to make the justification a little more prominent.

I am prepping a third screencast to cover it.

from lodash.

jeremyckahn avatar jeremyckahn commented on May 4, 2024

@jdalton

Ok, all Rekapi unit tests pass with the edge version of Lo-Dash.

Sweet! Thanks for this, I am updating the Rekapi repo to easily switch between Lo-Dash and Underscore now.

from lodash.

iwyg avatar iwyg commented on May 4, 2024

This is nice. I'll give this a try

from lodash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.