GithubHelp home page GithubHelp logo

Comments (4)

gyrfalcon avatar gyrfalcon commented on June 2, 2024 1

Just wanted to update this here, the project where I was running into this issue has been updated to use app-specific Type and Import values and the flow errors are gone.

I also updated the branch linked above with changes that get flow to pass. If desired I can turn that into a PR so there's a test for this.

from flow-degen.

LoganBarnett avatar LoganBarnett commented on June 2, 2024

We had some discussion about this. I think this can be a little confusing. The CustomImport: string that we see all over the generators is basically saying that CustomImport is constrained by string and not a type alias of string. This allows us to do string things with CustomImport, but since it's an externally provided type, it could be further constrained by other things.

As far as a fix goes, @gyrfalcon will need to remove CustomImport (and possibly CustomType), and instead use the application-specific types that CustomImport and CustomType are meant to represent. This means in the custom generator the type params should be stripped from customDegen.

I'll leave this open for now - I feel like the actionable thing to do here is to document the expectations, and, I think, correct the type signature used in the custom generator example.

from flow-degen.

LoganBarnett avatar LoganBarnett commented on June 2, 2024

Retroactive tests for existing behavior (and docs to go with it?!) are always appreciated!

from flow-degen.

LoganBarnett avatar LoganBarnett commented on June 2, 2024

The related pull request (#14) has been merged so this should be addressed now. Closing.

from flow-degen.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.