GithubHelp home page GithubHelp logo

Comments (3)

loganfsmyth avatar loganfsmyth commented on September 26, 2024

Thanks for the report, it looks like the first is probably an edge case that I missed. I'm thinking that class properties aren't currently working on classes that have parent classes. Does that seem likely to be the issue for the class that is throwing Decorating class property failed. Please ensure that transform-class-properties is enabled? I added that error exactly because I was worried I'd missed instances, so at least it's working :D

I think your second issue may be a side-effect of your "fix" first the first. Adding 'transform-class-properties' to your plugin list before the decorator plugin looks like it'll actually delete all the decorated class props before they can be processed by the decorator plugin, so if you revert that to just stage-1 and I fix the first issue, I think you'll be set.

from babel-plugin-transform-decorators-legacy.

loganfsmyth avatar loganfsmyth commented on September 26, 2024

Okay, I've pushed out a 1.3.4 to address this. Can you report back and let me know if it fixes your issue? Update decorators-legacy and delete 'transform-class-properties' from your plugins list and I think things should work.

from babel-plugin-transform-decorators-legacy.

kmalakoff avatar kmalakoff commented on September 26, 2024

Excellent! I've done the steps you suggested and tested my build with Babel 6...and it works!

I'm going to unsubscribe from https://phabricator.babeljs.io/T2645 since I have what I need now. If you want to write a quick note there to respond to my question about the repurposing of the issue, it might help people decide to unsubscribe (I also find it a little spammy / chatty...it would be great if there weren't notification emails for people being added and removed be default).

I really appreciate you writing this plugin to get people over to Babel 6! Onto the future...

from babel-plugin-transform-decorators-legacy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.