Content Style Not Being Applied Correctly about redraft

[richtera]

Yup, code should be

const arraysEqual = (arr1, arr2) => {
  if (arr1.length !== arr2.length) {
    return false;
  }
  // defining for loops with airbnb config is a pain maybe should disable some rules
  // eslint-disable-next-line
  for (let i = 0; i < arr1.length; i++) {
    if (arr1[i] !== arr2[i]) {
      return false;
    }
  }
  return true;
};

[lokiuz]

Merged the PR, but as I said there would still be nice to add a test case for this.

[adjesusds]

Say we have Draft.js implemented as our primary rich-text editor.

The above image can be represented as the following JSON:

{
  inlineStyleRanges: [
    { length: 6, offset: 0, style: 'bgcolor-rgb(251,160,38)' },
    { length: 6, offset: 6, style: 'bgcolor-rgb(97,189,109)' },
  ],
  text: 'Lorem ipsum.',
}

The issue here is that these two styles are subsequent to each other, and they both have the same amount of styles.

On an effort to reduce the amount of markup generated, when deciding whether or not to reuse the same ContentNode, the arraysEqual function will fail, due to the bug described above.

Leading to the first set of rules overlapping any subsequent one with an equal amount of styles.

[richtera]

Is this PR in npm? I didn't see a new compile.

[adjesusds]

The fix is now on master, but it hasn't made it to a release yet.

[richtera]

But this is an obvious typo where the code has for(init; inc; cond) { } instead of for(init; cond; inc) { }. Should we compile the code into the fork and install from there or would you be able to post this into npm soon?

[lokiuz]

I will push a new version to npm in a few hours.

[lokiuz]

Published 0.10.1 with the patch.

[richtera]

Awesome, thank you.