GithubHelp home page GithubHelp logo

Remove spaces in `extras_require` about medpy HOT 5 CLOSED

loli avatar loli commented on May 26, 2024
Remove spaces in `extras_require`

from medpy.

Comments (5)

loli avatar loli commented on May 26, 2024

Apparently, using spaces in dictionary keys is absolutely valid, as discussed in https://stackoverflow.com/questions/13474957/spaces-in-python-dictionary-keys. But I can see your point that it becomes inconvenient in this case.

On the other hand, the itk package can't be installed via pip. Please see the documentation (https://loli.github.io/medpy/) for detailed instructions on how to compile ITK with Python wrappers.

from medpy.

cancan101 avatar cancan101 commented on May 26, 2024

I wasn't referring to spaces in dictionary keys in general, I was specifically referring to extra requires. Also I think there is now a wheel for itk so I think It can be pip installed.

from medpy.

loli avatar loli commented on May 26, 2024

You're right, that's amazing. Thank you for pointing this out to me!

https://blog.kitware.com/itk-is-on-pypi-pip-install-itk-is-here/

Did you already tried if the medpy IO with that version of ITK?

from medpy.

cancan101 avatar cancan101 commented on May 26, 2024

Ok given that people probably were not using that extra (and that It didn't work until recently) what do you think about renaming it to all or extra_formats or itk?

from medpy.

loli avatar loli commented on May 26, 2024

I would go with extra_formats, since that's the sole purpose of the itk module in MedPy. If you want, you can make the adjustment and create a pull request. Otherwise I'll fix it when I get around to it.

from medpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.