GithubHelp home page GithubHelp logo

Comments (6)

sarahelsaig avatar sarahelsaig commented on June 12, 2024

Microsoft.AspNetCore.Http is now deprecated. Remove it and use a substitute if necessary.

Correct me if I'm wrong, but as I understand only the NuGet package is deprecated. So we don't have to change code, just use <FrameworkReference> instead of <PackageReference>:

With the release of .NET Core 3.0, many ASP.NET Core assemblies are no longer published to NuGet as packages. Instead, the assemblies are included in the Microsoft.AspNetCore.App shared framework, which is installed with the .NET Core SDK and runtime installers. For a list of packages no longer being published, see Remove obsolete package references.

from open-source-orchard-core-extensions.

sarahelsaig avatar sarahelsaig commented on June 12, 2024

Hmm, looks like we only have this problem in Lombiq.OrchardCoreApiClient which is netstandard2.0 so the framework reference can't be used. But it's only for a single IFormFile Recipe property in one of the API models. And that property is not used anywhere in OSOE, Lombiq-Tenants, or Dotnest-Tenants-Core. (is Lombiq.OrchardCoreApiClient used anywhere else?) I think it's safe to replace that property's type with JToken, so if anyone wants it they can still deserialize it as IFormFile in an assembly that has access to ASP.NET Core. Creating a new POCO that represents an IFormFile API response is an option too, but seems pointless.

from open-source-orchard-core-extensions.

Piedone avatar Piedone commented on June 12, 2024

Next time before merging please actually wait for an answer. Also @Psichorex.

from open-source-orchard-core-extensions.

sarahelsaig avatar sarahelsaig commented on June 12, 2024

So what's the answer?

from open-source-orchard-core-extensions.

sarahelsaig avatar sarahelsaig commented on June 12, 2024

@Piedone We are still supposed to use <TargetFramework>net6.0</TargetFramework>, right? Because there is at least one package that couldn't be updated to the latest release version because

Lombiq.Tests.csproj: [NU1202] Package Microsoft.AspNetCore.Mvc.Testing 7.0.8 is not compatible with net6.0 (.NETCoreApp,Version=v6.0). Package Microsoft.AspNetCore.Mvc.Testing 7.0.8 supports: net7.0 (.NETCoreApp,Version=v7.0)

from open-source-orchard-core-extensions.

Piedone avatar Piedone commented on June 12, 2024

Add a new property, keep the old one with [Obsolete], and document that removing the latter also needs the package reference removed. Then, we'll remove it with the next major release.

Yes, we still need to target .NET 6 (but build under the .NET 7 SDK).

from open-source-orchard-core-extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.