longshotlabs / mongo-object Goto Github PK

Not a bug, but a question - there are a bunch of places where setValueForPosition is called, including in a loop at the end of the forEachNode function. In the situation that a setValueForPosition necessitates calling _reParseObj - does this have to happen before the (immediately) next call to setValueForPosition executes? E.g., in forEachNode

    // Actually update/remove values as instructed
    Object.keys(updatedValues).forEach((position) => {
      this.setValueForPosition(position, updatedValues[position]);
    });

Today I had a hard time debugging when trying to find out why a library I use doesn't work as expected.
The base root cause is by this library which checks if an object is a base-object.

It tries to do so by checking the prototype of new Object().

As I found out today, the prototype of a new object is not always the same. This becomes evident when running your code in a NodeJS vm.

const vm = require('vm');
global.MongoObject = require('mongo-object').default;


console.log(vm.runInNewContext(`MongoObject.isBasicObject({})`, { MongoObject: MongoObject }));
console.log(vm.runInThisContext(`MongoObject.isBasicObject({})`));

console.log(MongoObject.isBasicObject({}));

false
true
true

🚨 The automated release from the main branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the main branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

No npm token specified.

An npm token must be created and set in the NPM_TOKEN environment variable on your CI environment.

Please make sure to create an npm token and to set it in the NPM_TOKEN environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/.

Good luck with your project ✨

Your semantic-release bot 📦🚀

The code in setValueForPosition only looks for array paths (foo[0]) but not for object paths (ex foo.bar).

This causes issues when trying to set paths like one.two[3].four.

I will be submitting a PR with a fix along with a test showing the issue.