BUG https://cdn.skypack.dev/ not found about discoverthreejs-site

[gisfinder]

the source file "vendor/three/build/three.module.js" is wrong.

[pflagerd]

I agree that the source file "vendor/three/build/three.module.js" looks wrong. It looks like html. But I cannot find where it is referenced in the source code anywhere. In fact, after finding a fix for the cdn.skypack.dev version problem, I removed the vendor/ directory entirely and suffered no ill effects. Code appeared to work the same.

[pflagerd]

I found that if I replaced 0.136.2 with 0.149.0, I could run MOST of the code examples. However, I also found a compatibility problem with the import in the controls.js file of those code examples that have controls.js (not all do).

import { OrbitControls} from 'https://cdn.skypack.dev/[email protected]/examples/jsm/controls/OrbitControls.js';

causes a Chrome/Chromium 118.0.5993.88 browser instance to complain in its console (and no scene is displayed) thus:

Uncaught TypeError: Failed to resolve module specifier "three". Relative references must start with either "/", "./", or "../".

Seems that the problem is somewhat unique to cdn.skypack.dev as replacing it with esm.sh or jspm.dev in the offending import results in the scene being correctly displayed.

e.g.

import { OrbitControls} from 'https://esm.sh/[email protected]/examples/jsm/controls/OrbitControls.js';

[pflagerd]

I guess I will work on replacing cdn.skypack.dev and changing the version number to 0.149.0 in my fork.

It would probably be wise to make it clear in the text of the site and/or the code examples themselves that we are using 0.149.0 which is not the most recent version.

[pflagerd]

Also begs the question "How about examples which use the npm import style for running locally?"