GithubHelp home page GithubHelp logo

Comments (2)

mdodgelooker avatar mdodgelooker commented on August 30, 2024

Hi @jeromyevans , thank you posting.

I'm curious what about your usage of filter components generally and specifically the breakage you are experiencing. The addition of AND/OR filters to Explore should be backward compatible in the sense that the shape of the query has not changed. The query.filter_expression (aka Lexp custom filter) will be more commonly used than before, whenever query filters use the OR operator across fields or groups. Does your UI currently render both query.filters and query.filter_expression or just the former? The logic on the Explore attempts to store filters to query.filters whenever possible.

As for plans to add open-source support for the AND/OR/grouping of filters, there are none immediately forthcoming, but please keep in touch with your account reps for more info.

from components.

jeromyevans avatar jeromyevans commented on August 30, 2024

We allow end-users to create/update schedule plans via API (create_scheduled_plan, update_scheduled_plan). To prepare a new scheduled plan for a Look, we'd fetch the Look and Fields and use the query.filters and query.filter_config and query.filter_expression to prepare a Filter component for each within our app.

In <24.0 if there's 4 filters it's always a list of 4 components: we prepare and render filter A, B, C and D, and the expression's state is inside each Filter.

In 24.0+ a user can defines a new filter group in the UI, such as "(A and B) or (C and D)" which is not possible in the old looker UI AFAIK. To render that the and/or between each group is outside the 4 Filter components. In the screenshot from Looker docs, the 4 filter components are nested in new containers that show this high-level grouping on the left. It may be possible to represent the same thing in an existing filter_expression but I don't think a user can construct equivalent on screen.

I expect we have to create a new parent component to handle the filter groups.

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.